Re: [PATCH] [RFC] allow admin/users to specify rto_min in milliseconds rather than jiffies

2007-09-13 Thread Stephen Hemminger
On Wed, 12 Sep 2007 13:28:42 -0700 Rick Jones [EMAIL PROTECTED] wrote: The api in netlink should be in milliseconds rather than compensating in the application (iproute2). My understanding of the in-kernel rtnetlink code is far from complete, but it doesn't seem to have much in the

Re: [PATCH] [RFC] allow admin/users to specify rto_min in milliseconds rather than jiffies

2007-09-13 Thread Rick Jones
Your observations are correct. rtnetlink can't/shouldn't be doing conversions itself. The 'ip' command should use a consistent unit for all values and do conversions if necessary. That being the case I'll start looking to see what is involved in leveraging the time conversion stuff in tc for

Re: [PATCH] [RFC] allow admin/users to specify rto_min in milliseconds rather than jiffies

2007-09-12 Thread Rick Jones
The api in netlink should be in milliseconds rather than compensating in the application (iproute2). My understanding of the in-kernel rtnetlink code is far from complete, but it doesn't seem to have much in the way of provisions for unit conversion, which would suggest no nice suffix-based

Re: [PATCH] [RFC] allow admin/users to specify rto_min in milliseconds rather than jiffies

2007-09-06 Thread Rick Jones
Stephen Hemminger wrote: On Tue, 4 Sep 2007 13:20:47 -0700 (PDT) Rick Jones [EMAIL PROTECTED] wrote: Build upon David Miller's initial patches to set the per-route rto_min so users can specify the rto_min in the same units (milliseconds) in which they are displayed. This is desirable because

Re: [PATCH] [RFC] allow admin/users to specify rto_min in milliseconds rather than jiffies

2007-09-05 Thread Stephen Hemminger
On Tue, 4 Sep 2007 13:20:47 -0700 (PDT) Rick Jones [EMAIL PROTECTED] wrote: Build upon David Miller's initial patches to set the per-route rto_min so users can specify the rto_min in the same units (milliseconds) in which they are displayed. This is desirable because asking users to convert

Re: [PATCH] [RFC] allow admin/users to specify rto_min in milliseconds rather than jiffies

2007-09-05 Thread Rick Jones
Stephen Hemminger wrote: On Tue, 4 Sep 2007 13:20:47 -0700 (PDT) Rick Jones [EMAIL PROTECTED] wrote: Build upon David Miller's initial patches to set the per-route rto_min so users can specify the rto_min in the same units (milliseconds) in which they are displayed. This is desirable because

[PATCH] [RFC] allow admin/users to specify rto_min in milliseconds rather than jiffies

2007-09-04 Thread Rick Jones
Build upon David Miller's initial patches to set the per-route rto_min so users can specify the rto_min in the same units (milliseconds) in which they are displayed. This is desirable because asking users to convert to and from jiffies themselves, when there can be different values of HZ from