Re: [PATCH] 3c59x: fix missing dma_mapping_error check

2018-01-03 Thread David Miller
From: Neil Horman Date: Wed, 3 Jan 2018 05:42:04 -0500 > On Tue, Jan 02, 2018 at 09:48:27PM -0500, David Miller wrote: >> And for the RX cases, it allows the RX ring to deplete to empty which >> tends to hang most chips. You need to make the DMA failure detection >> early and recycle the RX buff

Re: [PATCH] 3c59x: fix missing dma_mapping_error check

2018-01-03 Thread Neil Horman
On Tue, Jan 02, 2018 at 09:48:27PM -0500, David Miller wrote: > From: Neil Horman > Date: Fri, 29 Dec 2017 11:40:10 -0500 > > > @@ -2067,6 +2072,9 @@ vortex_start_xmit(struct sk_buff *skb, struct > > net_device *dev) > > int len = (skb->len + 3) & ~3; > > vp->tx_skb_dma =

Re: [PATCH] 3c59x: fix missing dma_mapping_error check

2018-01-02 Thread David Miller
From: Neil Horman Date: Fri, 29 Dec 2017 11:40:10 -0500 > @@ -2067,6 +2072,9 @@ vortex_start_xmit(struct sk_buff *skb, struct > net_device *dev) > int len = (skb->len + 3) & ~3; > vp->tx_skb_dma = pci_map_single(VORTEX_PCI(vp), skb->data, len, >

[PATCH] 3c59x: fix missing dma_mapping_error check

2017-12-29 Thread Neil Horman
A few spots in 3c59x missed calls to dma_mapping_error checks, casuing WARN_ONS to trigger. Clean those up. Signed-off-by: Neil Horman CC: Steffen Klassert CC: "David S. Miller" Reported-by: tedheads...@gmail.com --- drivers/net/ethernet/3com/3c59x.c | 17 +++-- 1 file changed, 15