Re: [PATCH] Add a driver for Renesas uPD60620 and uPD60620A PHYs

2017-10-08 Thread Bernd Edlinger
Hi Andrew, sorry for delayed reply. Looks like I did not receive a copy of your e-mail. >> Do you suggest that there are cases where auto negotiation does not >> reach completion, and still provides a usable link status? > > My experience is that it often return 10/half, since everything

Re: [PATCH] Add a driver for Renesas uPD60620 and uPD60620A PHYs

2017-09-28 Thread Andrew Lunn
Hi Bernd > >> + if (phy_state & BMSR_ANEGCOMPLETE) { > > > > It is worth comparing this against genphy_read_status() which is the > > reference implementation. You would normally check if auto negotiation > > is enabled, not if it has completed. If it is enabled you read the > > current

Re: [PATCH] Add a driver for Renesas uPD60620 and uPD60620A PHYs

2017-09-28 Thread Bernd Edlinger
On 09/22/17 19:59, Andrew Lunn wrote: > On Fri, Sep 22, 2017 at 05:08:45PM +, Bernd Edlinger wrote: >> >> +config RENESAS_PHY >> +tristate "Driver for Renesas PHYs" >> +---help--- >> + Supports the uPD60620 and uPD60620A PHYs. >> + > > Hi Bernd > > Please call this "Reneseas

Re: [PATCH] Add a driver for Renesas uPD60620 and uPD60620A PHYs

2017-09-22 Thread Andrew Lunn
On Fri, Sep 22, 2017 at 05:08:45PM +, Bernd Edlinger wrote: > Signed-off-by: Bernd Edlinger > --- > drivers/net/phy/Kconfig| 5 + > drivers/net/phy/Makefile | 1 + > drivers/net/phy/uPD60620.c | 226 > + >

[PATCH] Add a driver for Renesas uPD60620 and uPD60620A PHYs

2017-09-22 Thread Bernd Edlinger
Signed-off-by: Bernd Edlinger --- drivers/net/phy/Kconfig| 5 + drivers/net/phy/Makefile | 1 + drivers/net/phy/uPD60620.c | 226 + 3 files changed, 232 insertions(+) create mode 100644