Re: [PATCH] Additional options for resetting packet statistics

2006-01-25 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article [EMAIL PROTECTED] (at Tue, 24 Jan 2006 16:38:26 -0800), Kris Katterjohn [EMAIL PROTECTED] says: + if (optlen != sizeof val) sizeof(val) Please use sizeof(foo) instead of sizeof foo. --- x/include/linux/if_packet.h 2006-01-24

Re: [PATCH] Additional options for resetting packet statistics

2006-01-25 Thread Kris Katterjohn
From: YOSHIFUJI Hideaki Sent: 1/25/2006 7:32:09 AM Hello. In article [EMAIL PROTECTED] (at Tue, 24 Jan 2006 16:38:26 -0800), Kris Katterjohn [EMAIL PROTECTED] says: + if (optlen != sizeof val) sizeof(val) Please use sizeof(foo) instead of

Re: [PATCH] Additional options for resetting packet statistics

2006-01-25 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article [EMAIL PROTECTED] (at Wed, 25 Jan 2006 09:13:26 -0800), Kris Katterjohn [EMAIL PROTECTED] says: + + case PACKET_ACCUMULATE_STATISTICS: + { + int val; + + if (optlen != sizeof(val)) + return -EINVAL; I think this is

Re: [PATCH] Additional options for resetting packet statistics

2006-01-24 Thread YOSHIFUJI Hideaki / 吉藤英明
Hello. In article [EMAIL PROTECTED] (at Sat, 7 Jan 2006 10:05:52 -0800), Kris Katterjohn [EMAIL PROTECTED] says: PACKET_AUTO_STATISTICS is the default and the kernel will zero the packet statistics when the PACKET_STATISTICS getsockopt() call is used. + case PACKET_AUTO_STATISTICS: +

Re: [PATCH] Additional options for resetting packet statistics

2006-01-24 Thread Kris Katterjohn
From: YOSHIFUJI Hideaki Sent: 1/24/2006 3:20:32 PM We can merge PACKET_AUTO_STATISTICS and PACKET_MANUAL_STATISTICS, into one, e.g. PACKET_ACCUMULATED_STATISTICS, and we can reuse PACKET_STATISTICS for resetting; case PACKET_ACCUMULATED_STATISTICS: { int val;

Re: [PATCH] Additional options for resetting packet statistics

2006-01-24 Thread Kris Katterjohn
From: Kris Katterjohn Sent: 1/24/2006 4:38:26 PM --- x/include/linux/if_packet.h 2006-01-24 18:27:41.0 -0600 +++ y/include/linux/if_packet.h 2006-01-24 17:50:02.0 -0600 @@ -37,8 +37,9 @@ struct sockaddr_ll #define PACKET_RECV_OUTPUT 3 /* Value 4 is

[PATCH] Additional options for resetting packet statistics

2006-01-07 Thread Kris Katterjohn
This adds some setsockopt(SOL_PACKET) options for changing the behavior when getting packet statistics from the kernel. Signed-off-by: Kris Katterjohn [EMAIL PROTECTED] This is a diff from 2.6.15 and I AM subscribed to netdev, so you dont' need to CC me anymore. I sent this to the linux-kernel