Re: [PATCH] Advertise PPPoE MTU / avoid memory leak.

2006-09-27 Thread Michal Ostrowski
This is not currently supported. Looking at the RFC, this is an issue that must be solved in the pppoe plugin that performs the PPPoE negotiation/discovery. The kernel code that runs the regular session traffic should be able to adjust (with minimal or no changes) as it does not depend on a

Re: [PATCH] Advertise PPPoE MTU / avoid memory leak.

2006-09-26 Thread Pekka Savola
Speaking of PPPoE and MTU, does Linux support recently-published RFC 4638: Accommodating a Maximum Transit Unit/Maximum Receive Unit (MTU/MRU) Greater Than 1492 in the Point-to-Point Protocol over Ethernet (PPPoE) On Sat, 23 Sep 2006, [EMAIL PROTECTED]

Re: [PATCH] Advertise PPPoE MTU / avoid memory leak.

2006-09-25 Thread Michal Ostrowski
On Sun, 2006-09-24 at 18:41 -0700, David Miller wrote: From: Michal Ostrowski [EMAIL PROTECTED] Date: Sun, 24 Sep 2006 07:29:25 -0500 I think the call path via dev-hard_start_xmit, if it fails, may result in an skb not being freed. This appears to be the case with the e100.c driver.

Re: [PATCH] Advertise PPPoE MTU / avoid memory leak.

2006-09-24 Thread Michal Ostrowski
On Sat, 2006-09-23 at 14:56 -0700, David Miller wrote: From: [EMAIL PROTECTED] Date: Sat, 23 Sep 2006 12:30:23 -0500 __pppoe_xmit must free any skb it allocates if there is an error submitting the skb downstream. This isn't right, dev_queue_xmit() can return -ENETDOWN and still free

Re: [PATCH] Advertise PPPoE MTU / avoid memory leak.

2006-09-24 Thread David Miller
From: Michal Ostrowski [EMAIL PROTECTED] Date: Sun, 24 Sep 2006 07:29:25 -0500 I think the call path via dev-hard_start_xmit, if it fails, may result in an skb not being freed. This appears to be the case with the e100.c driver. The qdisc_restart path to dev-hard_start_xmit also appears

[PATCH] Advertise PPPoE MTU / avoid memory leak.

2006-09-23 Thread mostrows
PPPoE must advertise the underlying device's MTU via the ppp channel descriptor structure, as multilink functionality depends on it. __pppoe_xmit must free any skb it allocates if there is an error submitting the skb downstream. Signed-off-by: Michal Ostrowski [EMAIL PROTECTED] ---

Re: [PATCH] Advertise PPPoE MTU / avoid memory leak.

2006-09-23 Thread David Miller
From: [EMAIL PROTECTED] Date: Sat, 23 Sep 2006 12:30:23 -0500 __pppoe_xmit must free any skb it allocates if there is an error submitting the skb downstream. This isn't right, dev_queue_xmit() can return -ENETDOWN and still free the SKB, so your change will cause the SKB to be freed up twice