Re: [PATCH] Evict tmp variable from the stack in ip6_evictor

2007-10-10 Thread Patrick McHardy
Pavel Emelyanov wrote: The list_head *tmp is used to help getting the first entry in the ip6_frag_lru_list list. There is a simpler way to do it The exact same code exists in ip_fragment.c and nf_conntrack_reasm.c, please also change it there. - To unsubscribe from this list: send the line

Re: [PATCH] Evict tmp variable from the stack in ip6_evictor

2007-10-10 Thread Pavel Emelyanov
Patrick McHardy wrote: Pavel Emelyanov wrote: The list_head *tmp is used to help getting the first entry in the ip6_frag_lru_list list. There is a simpler way to do it The exact same code exists in ip_fragment.c and nf_conntrack_reasm.c, please also change it there. Hm, indeed. But I see

[PATCH] Evict tmp variable from the stack in ip6_evictor

2007-10-10 Thread Pavel Emelyanov
The list_head *tmp is used to help getting the first entry in the ip6_frag_lru_list list. There is a simpler way to do it. Signed-off-by: Pavel Emelyanov [EMAIL PROTECTED] --- diff --git a/net/ipv6/reassembly.c b/net/ipv6/reassembly.c index 31601c9..8fad98b 100644 --- a/net/ipv6/reassembly.c

Re: [PATCH] Evict tmp variable from the stack in ip6_evictor

2007-10-10 Thread Patrick McHardy
Pavel Emelyanov wrote: Patrick McHardy wrote: Pavel Emelyanov wrote: The list_head *tmp is used to help getting the first entry in the ip6_frag_lru_list list. There is a simpler way to do it The exact same code exists in ip_fragment.c and nf_conntrack_reasm.c, please also change it there.

Re: [PATCH] Evict tmp variable from the stack in ip6_evictor

2007-10-10 Thread David Miller
From: Patrick McHardy [EMAIL PROTECTED] Date: Wed, 10 Oct 2007 17:06:07 +0200 Pavel Emelyanov wrote: Patrick McHardy wrote: Pavel Emelyanov wrote: The list_head *tmp is used to help getting the first entry in the ip6_frag_lru_list list. There is a simpler way to do it The exact same