Re: [PATCH] I.MX6: Fix Ethernet PHY mode on Ventana boards

2015-12-09 Thread Tim Harvey
On Tue, Dec 8, 2015 at 9:50 PM, Krzysztof Hałasa wrote: > David Miller writes: > >> Since this only touched DT files in the ARM platform code, maybe >> the ARM tree is the best path for this patch rather than mine? > > I think so. > > Tim, would you like to handle this patch yourself, or should I

Re: [PATCH] I.MX6: Fix Ethernet PHY mode on Ventana boards

2015-12-08 Thread Krzysztof Hałasa
David Miller writes: > Since this only touched DT files in the ARM platform code, maybe > the ARM tree is the best path for this patch rather than mine? I think so. Tim, would you like to handle this patch yourself, or should I send it to the ARM contacts? -- Krzysztof Halasa Industrial Resea

Re: [PATCH] I.MX6: Fix Ethernet PHY mode on Ventana boards

2015-12-08 Thread David Miller
From: khal...@piap.pl (Krzysztof Hałasa) Date: Mon, 07 Dec 2015 13:56:23 +0100 > Gateworks Ventana boards seem to need "RGMII-ID" (internal delay) > PHY mode, instead of simple "RGMII", for their Marvell 88E1510 > transceiver. Otherwise, the Ethernet MAC doesn't work with Marvell PHY > driver (TX

Re: [PATCH] I.MX6: Fix Ethernet PHY mode on Ventana boards

2015-12-08 Thread Andrew Lunn
> This may be a stupid question but what does the Marvell phy driver > offer that the generic phy driver does not? It reliably configures the RGMII delays :-) No need to depend on your bootloader doing it. It allows interrupts to be used instead of polling the PHY all the time, assuming you have

Re: [PATCH] I.MX6: Fix Ethernet PHY mode on Ventana boards

2015-12-08 Thread Tim Harvey
On Tue, Dec 8, 2015 at 6:13 AM, Krzysztof Hałasa wrote: > Tim Harvey writes: > >> It sounds like your saying this controls whether the phy is in charge >> of delay vs the MAC. I have never needed to set this and haven't found >> where its actually used (in at least 4.3). Is this caused by somethi

Re: [PATCH] I.MX6: Fix Ethernet PHY mode on Ventana boards

2015-12-08 Thread Krzysztof Hałasa
Tim Harvey writes: > It sounds like your saying this controls whether the phy is in charge > of delay vs the MAC. I have never needed to set this and haven't found > where its actually used (in at least 4.3). Is this caused by something > new in the kernel I haven't seen yet or is it possible you

Re: [PATCH] I.MX6: Fix Ethernet PHY mode on Ventana boards

2015-12-07 Thread Tim Harvey
On Mon, Dec 7, 2015 at 4:56 AM, Krzysztof Hałasa wrote: > Gateworks Ventana boards seem to need "RGMII-ID" (internal delay) > PHY mode, instead of simple "RGMII", for their Marvell 88E1510 > transceiver. Otherwise, the Ethernet MAC doesn't work with Marvell PHY > driver (TX doesn't seem to work co

Re: [PATCH] I.MX6: Fix Ethernet PHY mode on Ventana boards

2015-12-07 Thread Fabio Estevam
On Mon, Dec 7, 2015 at 10:56 AM, Krzysztof Hałasa wrote: > Gateworks Ventana boards seem to need "RGMII-ID" (internal delay) > PHY mode, instead of simple "RGMII", for their Marvell 88E1510 > transceiver. Otherwise, the Ethernet MAC doesn't work with Marvell PHY > driver (TX doesn't seem to work c

[PATCH] I.MX6: Fix Ethernet PHY mode on Ventana boards

2015-12-07 Thread Krzysztof Hałasa
Gateworks Ventana boards seem to need "RGMII-ID" (internal delay) PHY mode, instead of simple "RGMII", for their Marvell 88E1510 transceiver. Otherwise, the Ethernet MAC doesn't work with Marvell PHY driver (TX doesn't seem to work correctly). Tested on GW5400 rev. C. This bug affects ARM Fedora