Re: [PATCH] Improve Atheros ethernet driver not to do order 4 GFP_ATOMIC allocation

2015-12-03 Thread Michal Hocko
On Wed 02-12-15 22:43:31, Chris Snook wrote: > On Tue, Dec 1, 2015 at 12:35 PM David Miller wrote: > > > From: Michal Hocko > > Date: Mon, 30 Nov 2015 14:21:29 +0100 > > > > > On Sat 28-11-15 15:51:13, Pavel Machek wrote: > > >> > > >> atl1c driver is

Re: [PATCH] Improve Atheros ethernet driver not to do order 4 GFP_ATOMIC allocation

2015-12-03 Thread Pavel Machek
On Tue 2015-12-01 15:36:28, David Miller wrote: > From: Eric Dumazet > Date: Mon, 30 Nov 2015 09:58:23 -0800 > > > On Sat, 2015-11-28 at 15:51 +0100, Pavel Machek wrote: > >> atl1c driver is doing order-4 allocation with GFP_ATOMIC > >> priority. That often breaks

Re: [PATCH] Improve Atheros ethernet driver not to do order 4 GFP_ATOMIC allocation

2015-12-02 Thread Pavel Machek
On Wed 2015-12-02 22:43:31, Chris Snook wrote: > On Tue, Dec 1, 2015 at 12:35 PM David Miller wrote: > > > From: Michal Hocko > > Date: Mon, 30 Nov 2015 14:21:29 +0100 > > > > > On Sat 28-11-15 15:51:13, Pavel Machek wrote: > > >> > > >> atl1c driver is

Re: [PATCH] Improve Atheros ethernet driver not to do order 4 GFP_ATOMIC allocation

2015-12-01 Thread David Miller
From: Eric Dumazet Date: Mon, 30 Nov 2015 09:58:23 -0800 > On Sat, 2015-11-28 at 15:51 +0100, Pavel Machek wrote: >> atl1c driver is doing order-4 allocation with GFP_ATOMIC >> priority. That often breaks networking after resume. Switch to >> GFP_KERNEL. Still not ideal,

Re: [PATCH] Improve Atheros ethernet driver not to do order 4 GFP_ATOMIC allocation

2015-12-01 Thread David Miller
From: Michal Hocko Date: Mon, 30 Nov 2015 14:21:29 +0100 > On Sat 28-11-15 15:51:13, Pavel Machek wrote: >> >> atl1c driver is doing order-4 allocation with GFP_ATOMIC >> priority. That often breaks networking after resume. Switch to >> GFP_KERNEL. Still not ideal, but

Re: [PATCH] Improve Atheros ethernet driver not to do order 4 GFP_ATOMIC allocation

2015-11-30 Thread Eric Dumazet
On Sat, 2015-11-28 at 15:51 +0100, Pavel Machek wrote: > atl1c driver is doing order-4 allocation with GFP_ATOMIC > priority. That often breaks networking after resume. Switch to > GFP_KERNEL. Still not ideal, but should be significantly better. > > Signed-off-by: Pavel Machek

Re: [PATCH] Improve Atheros ethernet driver not to do order 4 GFP_ATOMIC allocation

2015-11-30 Thread Michal Hocko
On Sat 28-11-15 15:51:13, Pavel Machek wrote: > > atl1c driver is doing order-4 allocation with GFP_ATOMIC > priority. That often breaks networking after resume. Switch to > GFP_KERNEL. Still not ideal, but should be significantly better. It is not clear why GFP_KERNEL can replace GFP_ATOMIC

Re: [PATCH] Improve Atheros ethernet driver not to do order 4 GFP_ATOMIC allocation

2015-11-29 Thread Sergei Shtylyov
Hello. On 11/28/2015 5:51 PM, Pavel Machek wrote: atl1c driver is doing order-4 allocation with GFP_ATOMIC priority. That often breaks networking after resume. Switch to GFP_KERNEL. Still not ideal, but should be significantly better. Signed-off-by: Pavel Machek diff --git

[PATCH] Improve Atheros ethernet driver not to do order 4 GFP_ATOMIC allocation

2015-11-28 Thread Pavel Machek
atl1c driver is doing order-4 allocation with GFP_ATOMIC priority. That often breaks networking after resume. Switch to GFP_KERNEL. Still not ideal, but should be significantly better. Signed-off-by: Pavel Machek diff --git a/drivers/net/ethernet/atheros/atl1c/atl1c_main.c