Re: [PATCH] PHYLIB: Add BCM5482 PHY support

2008-02-01 Thread Jeff Garzik
Nate Case wrote: This Broadcom PHY is similar to other bcm54xx devices. Signed-off-by: Nate Case <[EMAIL PROTECTED]> --- drivers/net/phy/broadcom.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) applied -- To unsubscribe from this list: send the line "unsubsc

Re: [PATCH] PHYLIB: Add BCM5482 PHY support

2008-01-30 Thread Nate Case
On Wed, 2008-01-30 at 09:51 +, Maciej W. Rozycki wrote: > > +static struct phy_driver bcm5482_driver = { > > +.phy_id= 0x0143bcb0, > > + .phy_id_mask= 0xfff0, > > Please check formatting above and also I am a bit curious as to why the > ID is so different from t

Re: [PATCH] PHYLIB: Add BCM5482 PHY support

2008-01-30 Thread Maciej W. Rozycki
On Tue, 29 Jan 2008, Nate Case wrote: > +static struct phy_driver bcm5482_driver = { > +.phy_id = 0x0143bcb0, > + .phy_id_mask= 0xfff0, Please check formatting above and also I am a bit curious as to why the ID is so different from the other ones -- the number is meant

[PATCH] PHYLIB: Add BCM5482 PHY support

2008-01-29 Thread Nate Case
This Broadcom PHY is similar to other bcm54xx devices. Signed-off-by: Nate Case <[EMAIL PROTECTED]> --- drivers/net/phy/broadcom.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/drivers/net/phy/broadcom.c b/drivers/net/phy/broadcom.c index 29666c8..5b