Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC.

2007-10-24 Thread Valentine Barshak
Benjamin Herrenschmidt wrote: On Tue, 2007-10-23 at 20:57 -0500, Valentine Barshak wrote: +static int m88e_init(struct mii_phy *phy) +{ + printk("%s: Marvell 88E Ethernet\n", __FUNCTION__); + phy_write(phy, 0x14, 0x0ce3); + phy_write(phy, 0x18, 0x4101); + phy_wri

Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC.

2007-10-23 Thread Benjamin Herrenschmidt
On Tue, 2007-10-23 at 20:57 -0500, Valentine Barshak wrote: > +static int m88e_init(struct mii_phy *phy) > +{ > + printk("%s: Marvell 88E Ethernet\n", __FUNCTION__); > + phy_write(phy, 0x14, 0x0ce3); > + phy_write(phy, 0x18, 0x4101); > + phy_write(phy, 0x09, 0x0e00); > +

Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC.

2007-10-23 Thread Josh Boyer
On Tue, 23 Oct 2007 11:13:48 -0500 Kumar Gala <[EMAIL PROTECTED]> wrote: > > On Oct 23, 2007, at 10:20 AM, Josh Boyer wrote: > > > On Mon, 15 Oct 2007 14:27:23 -0400 > > Jeff Garzik <[EMAIL PROTECTED]> wrote: > > > >> Valentine Barshak wrote: > >>> This patch adds BCM5248 and Marvell 88E PHY

Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC.

2007-10-23 Thread Kumar Gala
On Oct 23, 2007, at 10:20 AM, Josh Boyer wrote: On Mon, 15 Oct 2007 14:27:23 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: Valentine Barshak wrote: This patch adds BCM5248 and Marvell 88E PHY support to NEW EMAC driver. These PHY chips are used on PowerPC 440EPx boards. The PHY code is

Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC.

2007-10-23 Thread Josh Boyer
On Mon, 15 Oct 2007 14:27:23 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Valentine Barshak wrote: > > This patch adds BCM5248 and Marvell 88E PHY support to NEW EMAC driver. > > These PHY chips are used on PowerPC 440EPx boards. > > The PHY code is based on the previous work by Stefan Roese

Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC.

2007-10-15 Thread Josh Boyer
On Tue, 2007-10-16 at 07:05 +1000, Benjamin Herrenschmidt wrote: > On Mon, 2007-10-15 at 15:04 -0400, Jeff Garzik wrote: > > I would ideally like a single active patch generator (even if they > > are > > merely reviewed others work sometimes). > > > > Outside of that, I'm hoping you and the other

Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC.

2007-10-15 Thread Benjamin Herrenschmidt
On Mon, 2007-10-15 at 15:04 -0400, Jeff Garzik wrote: > I would ideally like a single active patch generator (even if they > are > merely reviewed others work sometimes). > > Outside of that, I'm hoping you and the other people listed making > changes will self-organize without my help :) Josh

Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC.

2007-10-15 Thread Benjamin Herrenschmidt
On Mon, 2007-10-15 at 14:53 -0400, Jeff Garzik wrote: > Roland Dreier (2): >ibm_new_emac: Nuke SET_MODULE_OWNER() use >ibm_emac: Convert to use napi_struct independent of struct > net_device > Wow, I'd have loved to be CCed at least on the last one since I was about to do just th

Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC.

2007-10-15 Thread Jeff Garzik
Josh Boyer wrote: On Mon, 15 Oct 2007 14:53:26 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: Seems sane to me -- ACK -- but we have multiple people sending me patches for a single driver. That's normal for janitorial cleanups across the whole tree, but discouraged when multiple people are activ

Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC.

2007-10-15 Thread Josh Boyer
On Mon, 15 Oct 2007 14:53:26 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > >> Seems sane to me -- ACK -- but we have multiple people sending me > >> patches for a single driver. That's normal for janitorial cleanups > >> across the whole tree, but discouraged when multiple people are actively

Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC.

2007-10-15 Thread Jeff Garzik
Josh Boyer wrote: On Mon, 15 Oct 2007 14:27:23 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: Valentine Barshak wrote: This patch adds BCM5248 and Marvell 88E PHY support to NEW EMAC driver. These PHY chips are used on PowerPC 440EPx boards. The PHY code is based on the previous work by Stef

Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC.

2007-10-15 Thread Josh Boyer
On Mon, 15 Oct 2007 14:27:23 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Valentine Barshak wrote: > > This patch adds BCM5248 and Marvell 88E PHY support to NEW EMAC driver. > > These PHY chips are used on PowerPC 440EPx boards. > > The PHY code is based on the previous work by Stefan Roese

Re: [PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC.

2007-10-15 Thread Jeff Garzik
Valentine Barshak wrote: This patch adds BCM5248 and Marvell 88E PHY support to NEW EMAC driver. These PHY chips are used on PowerPC 440EPx boards. The PHY code is based on the previous work by Stefan Roese <[EMAIL PROTECTED]> Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> Signed-off-by: Va

[PATCH] PowerPC: Add BCM5248 and Marvell 88E1111 PHY support to NEW EMAC.

2007-10-15 Thread Valentine Barshak
This patch adds BCM5248 and Marvell 88E PHY support to NEW EMAC driver. These PHY chips are used on PowerPC 440EPx boards. The PHY code is based on the previous work by Stefan Roese <[EMAIL PROTECTED]> Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> Signed-off-by: Valentine Barshak <[EMAIL PRO