On 1/23/07, Thibaut VARENE <[EMAIL PROTECTED]> wrote:
- As Jarek pointed out, you're checking twice the value of
mp->tx_desc_count, which means dereferencing a pointer and accessing
memory twice. I don't know how perf-critical this bit of code is, but
I wonder which of keeping the lock for a long
On 1/22/07, Dale Farnsworth <[EMAIL PROTECTED]> wrote:
Jarek and Thibaut,
Thank you both very much for your work finding and fixing this bug.
Jarek, can you verify that the following patch fixes the problem you
were seeing?
-Dale
Hi Dale,
The patch seems to work fine. Just thinking out loud
On Mon, Jan 22, 2007 at 10:06:16AM -0700, Dale Farnsworth wrote:
> Jarek and Thibaut,
>
> Thank you both very much for your work finding and fixing this bug.
> Jarek, can you verify that the following patch fixes the problem you
> were seeing?
>
> -Dale
Sorry, only Thibaut can verify this. I don
Jarek and Thibaut,
Thank you both very much for your work finding and fixing this bug.
Jarek, can you verify that the following patch fixes the problem you
were seeing?
-Dale
- Patch follows -
From: Dale Farnsworth <[EMAIL PROTECTED]>
mv643xx_eth: Fix race condition in mv643xx_eth_free
On Sun, Jan 21, 2007 at 02:02:15PM +0100, Thibaut VARENE wrote:
> On 1/21/07, Thibaut VARENE <[EMAIL PROTECTED]> wrote:
...
> >Hmm, I think this is guaranteed not to work. In between those lines
> >the lock is released, while data in the mp structure is still being
> >accessed. It seems that this b
On 1/21/07, Thibaut VARENE <[EMAIL PROTECTED]> wrote:
On 1/11/07, Jarek Poplawski <[EMAIL PROTECTED]> wrote:
>
> PS: alas I didn't even check compiling - I had no time to
> find all compile dependencies of this driver
> ---
Hmm, I think this is guaranteed not to work. In between those lines
the l
On 1/11/07, Jarek Poplawski <[EMAIL PROTECTED]> wrote:
PS: alas I didn't even check compiling - I had no time to
find all compile dependencies of this driver
---
Signed-off-by: Jarek Poplawski <[EMAIL PROTECTED]>
---
diff -Nurp linux-2.6.20-rc4-/drivers/net/mv643xx_eth.c
linux-2.6.20-rc4/driv
On Wed, Jan 10, 2007 at 06:12:29PM +0100, Thibaut VARENE wrote:
> On 1/9/07, Thibaut VARENE <[EMAIL PROTECTED]> wrote:
> >On 1/9/07, Dale Farnsworth <[EMAIL PROTECTED]> wrote:
> >>
> >> Thank you Thibaut. Please try the following patch:
> >>
> >> From: Dale Farnsworth <[EMAIL PROTECTED]>
> >>
> >>
