Re: [PATCH] SNMPv2 udpInDatagrams counter error

2006-07-31 Thread Herbert Xu
Wei Yongjun <[EMAIL PROTECTED]> wrote: > > I also send the same mail several ago, and get no response. You > patch is fine. But I think following code has no effect: > > if (sk->sk_filter && skb->ip_summed != CHECKSUM_UNNECESSARY) { > > It just let UDP datagrams with checksum error be added into

Re: [PATCH] SNMPv2 udpInDatagrams counter error

2006-07-31 Thread Wei Yongjun
This change does not effect to tcpdump, only let UDP filter can not received UDP datagrams with checksum error. It is not a good idea, but I think is the best way to resolve this problem. If you want to capture error UDP packet, you can used tcpdump. On Monday 31 July 2006 04:57, Gerrit Renker wr

Re: [PATCH] SNMPv2 udpInDatagrams counter error

2006-07-31 Thread Wei Yongjun
cho reply. - Original Message - From: "Gerrit Renker" <[EMAIL PROTECTED]> To: Sent: Monday, July 31, 2006 4:19 PM Subject: Re: [PATCH] SNMPv2 udpInDatagrams counter error > This has been raised earlier, cf. http://bugzilla.kernel.org/show_bug.cgi?id=6660 > > Wei

Re: [PATCH] SNMPv2 udpInDatagrams counter error

2006-07-31 Thread Gerrit Renker
Hi, | if (!sk->sk_filter && skb->ip_summed != CHECKSUM_UNNECESSARY) { | | IPv6 doesn't do this, so I think delete condition 'sk->sk_filter' is better. | Do you think so? I think the sk->sk_filter is there for a good reason. If you delete it, that routine is forced to always compute UDP ch

Re: [PATCH] SNMPv2 udpInDatagrams counter error

2006-07-31 Thread Gerrit Renker
This has been raised earlier, cf. http://bugzilla.kernel.org/show_bug.cgi?id=6660 Wei Yongjun wrote: | When I send a UDP datagrams with checksum error to target, I found that: | Under IPv6, counter udpInErrors increased, but under IPv4 counter | udpInDatagrams increased. I lookup into the sour

[PATCH] SNMPv2 udpInDatagrams counter error

2006-07-31 Thread Wei Yongjun
When I send a UDP datagrams with checksum error to target, I found that: Under IPv6, counter udpInErrors increased, but under IPv4 counter udpInDatagrams increased. I lookup into the source code, and found that, under IPv4 UDP datagrams with checksum error will be delivered to UDP receive queue, bu