Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

2017-05-31 Thread Michael Büsch
On Wed, 31 May 2017 19:07:15 -0500 Larry Finger wrote: > On 05/31/2017 10:32 AM, Michael Büsch wrote: > > On Wed, 31 May 2017 13:26:43 +0300 > > Kalle Valo wrote: > > > >> Jia-Ju Bai writes: > >> > >>> The driver may

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

2017-05-31 Thread Michael Büsch
On Thu, 01 Jun 2017 07:27:20 +0300 Kalle Valo wrote: > Michael Büsch writes: > > >> > --- a/drivers/net/wireless/broadcom/b43legacy/main.c > >> > +++ b/drivers/net/wireless/broadcom/b43legacy/main.c > >> > @@ -2859,7 +2859,9 @@ static void

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

2017-05-31 Thread Kalle Valo
Michael Büsch writes: >> > --- a/drivers/net/wireless/broadcom/b43legacy/main.c >> > +++ b/drivers/net/wireless/broadcom/b43legacy/main.c >> > @@ -2859,7 +2859,9 @@ static void b43legacy_op_bss_info_changed(struct >> > ieee80211_hw *hw, >> >b43legacy_write32(dev,

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

2017-05-31 Thread Jia-Ju Bai
On 06/01/2017 08:07 AM, Larry Finger wrote: On 05/31/2017 10:32 AM, Michael Büsch wrote: On Wed, 31 May 2017 13:26:43 +0300 Kalle Valo wrote: Jia-Ju Bai writes: The driver may sleep under a spin lock, and the function call path is:

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

2017-05-31 Thread Larry Finger
On 05/31/2017 10:32 AM, Michael Büsch wrote: On Wed, 31 May 2017 13:26:43 +0300 Kalle Valo wrote: Jia-Ju Bai writes: The driver may sleep under a spin lock, and the function call path is: b43legacy_op_bss_info_changed (acquire the lock by

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

2017-05-31 Thread Michael Büsch
On Wed, 31 May 2017 13:26:43 +0300 Kalle Valo wrote: > Jia-Ju Bai writes: > > > The driver may sleep under a spin lock, and the function call path is: > > b43legacy_op_bss_info_changed (acquire the lock by spin_lock_irqsave) > >

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

2017-05-31 Thread Arend van Spriel
On 31-05-17 12:26, Kalle Valo wrote: > Jia-Ju Bai writes: > >> The driver may sleep under a spin lock, and the function call path is: >> b43legacy_op_bss_info_changed (acquire the lock by spin_lock_irqsave) >> b43legacy_synchronize_irq >> synchronize_irq --> may sleep

Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

2017-05-31 Thread Kalle Valo
Jia-Ju Bai writes: > The driver may sleep under a spin lock, and the function call path is: > b43legacy_op_bss_info_changed (acquire the lock by spin_lock_irqsave) > b43legacy_synchronize_irq > synchronize_irq --> may sleep > > To fix it, the lock is released before

[PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_op_bss_info_changed

2017-05-31 Thread Jia-Ju Bai
The driver may sleep under a spin lock, and the function call path is: b43legacy_op_bss_info_changed (acquire the lock by spin_lock_irqsave) b43legacy_synchronize_irq synchronize_irq --> may sleep To fix it, the lock is released before b43legacy_synchronize_irq, and the lock is acquired