Re: [PATCH] bna: integer overflow bug in debugfs

2017-03-21 Thread David Miller
From: Dan Carpenter Date: Fri, 17 Mar 2017 23:52:35 +0300 > We could allocate less memory than intended because we do: > > bnad->regdata = kzalloc(len << 2, GFP_KERNEL); > > The shift can overflow leading to a crash. This is debugfs code so the > impact is very

RE: [PATCH] bna: integer overflow bug in debugfs

2017-03-20 Thread Mody, Rasesh
> From: Dan Carpenter [mailto:dan.carpen...@oracle.com] > Sent: Friday, March 17, 2017 1:53 PM > > We could allocate less memory than intended because we do: > > bnad->regdata = kzalloc(len << 2, GFP_KERNEL); > > The shift can overflow leading to a crash. This is debugfs code so the

[PATCH] bna: integer overflow bug in debugfs

2017-03-17 Thread Dan Carpenter
We could allocate less memory than intended because we do: bnad->regdata = kzalloc(len << 2, GFP_KERNEL); The shift can overflow leading to a crash. This is debugfs code so the impact is very small. Fixes: 7afc5dbde091 ("bna: Add debugfs interface.") Signed-off-by: Dan Carpenter