Re: [PATCH] bnx2x: drop packets where gso_size is too big for hardware

2017-09-18 Thread Eric Dumazet
On Mon, 2017-09-18 at 14:41 +1000, Daniel Axtens wrote: > Hi Eric, ... > So I've been experimenting with this and reading through the core > networking code. If my understanding is correct, disabling GSO will > cause the packet to be segmented, but it will be segemented into > gso_size+header

Re: [PATCH] bnx2x: drop packets where gso_size is too big for hardware

2017-09-17 Thread Daniel Axtens
Hi Eric, >> +if (unlikely(skb_shinfo(skb)->gso_size + hlen > >> MAX_PACKET_SIZE)) { >> +BNX2X_ERR("reported gso segment size plus headers " >> + "(%d + %d) > MAX_PACKET_SIZE; dropping pkt!", >> +

Re: [PATCH] bnx2x: drop packets where gso_size is too big for hardware

2017-08-31 Thread Daniel Axtens
Eric Dumazet writes: > If you had this test in bnx2x_features_check(), packet could be > segmented by core networking stack before reaching bnx2x_start_xmit() by > clearing NETIF_F_GSO_MASK > > -> No drop would be involved. Thanks for the pointer - networking code is all

Re: [PATCH] bnx2x: drop packets where gso_size is too big for hardware

2017-08-31 Thread Eric Dumazet
On Thu, 2017-08-31 at 15:46 +1000, Daniel Axtens wrote: > If a bnx2x card is passed a GSO packet with a gso_size larger than > ~9700 bytes, it will cause a firmware error that will bring the card > down: > > bnx2x: [bnx2x_attn_int_deasserted3:4323(enP24p1s0f0)]MC assert! > bnx2x:

[PATCH] bnx2x: drop packets where gso_size is too big for hardware

2017-08-30 Thread Daniel Axtens
If a bnx2x card is passed a GSO packet with a gso_size larger than ~9700 bytes, it will cause a firmware error that will bring the card down: bnx2x: [bnx2x_attn_int_deasserted3:4323(enP24p1s0f0)]MC assert! bnx2x: [bnx2x_mc_assert:720(enP24p1s0f0)]XSTORM_ASSERT_LIST_INDEX 0x2 bnx2x: