Re: [PATCH] codel: add forgotten inline to functions in header file

2016-02-11 Thread Grumbach, Emmanuel
fixing linux-wireless address ... On 02/11/2016 04:30 PM, Eric Dumazet wrote: > On Thu, 2016-02-11 at 16:08 +0200, Emmanuel Grumbach wrote: >> Signed-off-by: Emmanuel Grumbach >> --- >> -static bool codel_should_drop(const struct sk_buff *skb, >> -

Re: [PATCH] codel: add forgotten inline to functions in header file

2016-02-11 Thread Eric Dumazet
On Thu, 2016-02-11 at 15:05 +, Grumbach, Emmanuel wrote: > Yeah :) codel_should_drop seemed very long indeed... I wanted to use the > codel_get_time and associated utils (_before, _after) in iwlwifi. > They're better than jiffies... So maybe I can just copy that code to > iwlwifi. You

[PATCH] codel: add forgotten inline to functions in header file

2016-02-11 Thread Emmanuel Grumbach
Signed-off-by: Emmanuel Grumbach --- include/net/codel.h | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff --git a/include/net/codel.h b/include/net/codel.h index 267e702..0775c24 100644 ---

Re: [PATCH] codel: add forgotten inline to functions in header file

2016-02-11 Thread Eric Dumazet
On Thu, 2016-02-11 at 16:08 +0200, Emmanuel Grumbach wrote: > Signed-off-by: Emmanuel Grumbach > --- > -static bool codel_should_drop(const struct sk_buff *skb, > - struct Qdisc *sch, > - struct codel_vars *vars, >

Re: [PATCH] codel: add forgotten inline to functions in header file

2016-02-11 Thread Grumbach, Emmanuel
On 02/11/2016 05:12 PM, Eric Dumazet wrote: > On Thu, 2016-02-11 at 15:05 +, Grumbach, Emmanuel wrote: > > >> Yeah :) codel_should_drop seemed very long indeed... I wanted to use the >> codel_get_time and associated utils (_before, _after) in iwlwifi. >> They're better than jiffies... So

Re: [PATCH] codel: add forgotten inline to functions in header file

2016-02-11 Thread Dave Taht
On Thu, Feb 11, 2016 at 7:05 AM, Grumbach, Emmanuel wrote: > fixing linux-wireless address ... > > On 02/11/2016 04:30 PM, Eric Dumazet wrote: >> On Thu, 2016-02-11 at 16:08 +0200, Emmanuel Grumbach wrote: >>> Signed-off-by: Emmanuel Grumbach

Re: [PATCH] codel: add forgotten inline to functions in header file

2016-02-11 Thread Dave Taht
On Thu, Feb 11, 2016 at 7:29 AM, Grumbach, Emmanuel wrote: > > > On 02/11/2016 05:12 PM, Eric Dumazet wrote: >> On Thu, 2016-02-11 at 15:05 +, Grumbach, Emmanuel wrote: >> >> >>> Yeah :) codel_should_drop seemed very long indeed... I wanted to use the >>>