From: Nicholas Mc Guire der.h...@hofr.at
Date: Sun, 7 Jun 2015 10:25:58 +0200
for the dscc4 case Im not sure - that seems to have gone in in 2.4
and that had HZ configurable. The cosa case was checked
again 2.2.26 (no config HZ) and the timeout there was 30 - 300ms.
I think that this is
On Sun, 07 Jun 2015, David Miller wrote:
From: Nicholas Mc Guire hof...@osadl.org
Date: Sat, 6 Jun 2015 09:51:51 +0200
@@ -517,7 +517,7 @@ static int cosa_probe(int base, int irq, int dma)
*/
set_current_state(TASK_INTERRUPTIBLE);
From: Nicholas Mc Guire hof...@osadl.org
Date: Sat, 6 Jun 2015 09:51:51 +0200
@@ -517,7 +517,7 @@ static int cosa_probe(int base, int irq, int dma)
*/
set_current_state(TASK_INTERRUPTIBLE);
cosa_putstatus(cosa, SR_TX_INT_ENA);
-
API compliance scanning with coccinelle flagged:
./drivers/net/wan/cosa.c:520:2-18: WARNING:
timeout (30) seems HZ dependent
Numeric constants passed to schedule_timeout() make the effective
timeout HZ dependent which makes little sense in a device probe.
Fixed up by converting the
