[PATCH] cxgb3 - convert to user struct device instead of class_device

2007-02-08 Thread Roland Dreier
Commit 43cb76d9 (Network: convert network devices to use struct device instead of class_device) breaks the just-merged cxgb3 driver, since the code that was merged predates the change and was not in the tree when Greg made the change. This patch fixes cxgb3 to build with the change. It also

Re: [PATCH] cxgb3 - convert to user struct device instead of class_device

2007-02-08 Thread Greg KH
On Thu, Feb 08, 2007 at 12:41:28PM -0800, Roland Dreier wrote: Commit 43cb76d9 (Network: convert network devices to use struct device instead of class_device) breaks the just-merged cxgb3 driver, since the code that was merged predates the change and was not in the tree when Greg made the

Re: [PATCH] cxgb3 - convert to user struct device instead of class_device

2007-02-08 Thread Roland Dreier
But I think Jeff already has a patch in the queue that makes this very change :) Really? I'm not sure I looked everywhere in Jeff's maze of git branches but I didn't see anything obvious in netdev-2.6.git when I looked before sending this. - R. - To unsubscribe from this list: send the

Re: [PATCH] cxgb3 - convert to user struct device instead of class_device

2007-02-08 Thread Jeff Garzik
Roland Dreier wrote: But I think Jeff already has a patch in the queue that makes this very change :) Really? I'm not sure I looked everywhere in Jeff's maze of git branches but I didn't see anything obvious in netdev-2.6.git when I looked before sending this. Andrew told me to drop it,

Re: [PATCH] cxgb3 - convert to user struct device instead of class_device

2007-02-08 Thread Roland Dreier
Andrew told me to drop it, so I dropped it :) That's odd -- do you know why? drivers/net/cxgb3 won't build at all in Linus's tree. I would have thought we want to fix it ASAP. - R. - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

Re: [PATCH] cxgb3 - convert to user struct device instead of class_device

2007-02-08 Thread Kumar Gala
On Feb 8, 2007, at 4:02 PM, Roland Dreier wrote: Andrew told me to drop it, so I dropped it :) That's odd -- do you know why? drivers/net/cxgb3 won't build at all in Linus's tree. I would have thought we want to fix it ASAP. I've posted a similar patch for drivers/net/gianfar_sysfs.c

Re: [PATCH] cxgb3 - convert to user struct device instead of class_device

2007-02-08 Thread Divy Le Ray
Roland Dreier wrote: But I think Jeff already has a patch in the queue that makes this very change :) Really? I'm not sure I looked everywhere in Jeff's maze of git branches but I didn't see anything obvious in netdev-2.6.git when I looked before sending this. - R. I pushed a fix in

Re: [PATCH] cxgb3 - convert to user struct device instead of class_device

2007-02-08 Thread Roland Dreier
I pushed a fix in the -mm tree as soon as the driver got committed there. I saw the patch committed in Jeff's upstream branch yesterday. It looks like it did not make it to Linus'tree though. OK, I missed that. In any case cxgb3 in Linus's tree doesn't build right now. What's the plan to

Re: [PATCH] cxgb3 - convert to user struct device instead of class_device

2007-02-08 Thread Jeff Garzik
Roland Dreier wrote: I pushed a fix in the -mm tree as soon as the driver got committed there. I saw the patch committed in Jeff's upstream branch yesterday. It looks like it did not make it to Linus'tree though. OK, I missed that. In any case cxgb3 in Linus's tree doesn't build right