Anton Arapov wrote:
So, now the way suggested by Denis looks reasonable.
What do you think?
If that's the case then you should fix __udp_lib_get_port() the same way.
Prevent division by zero in __udp_lib_get_port() when only one
unsecured port is available.
-Brian
Signed-off-by: Bria
David Miller <[EMAIL PROTECTED]> writes:
> From: Anton Arapov <[EMAIL PROTECTED]>
> Date: Wed, 10 Oct 2007 11:56:23 +0200
>
>> Yep, that's exactly I'm talking about. I'm sure that
>> [...] % (high - low) [...] erroneous from the begining, because
>> in such places we want to have 1 in denomina
From: Anton Arapov <[EMAIL PROTECTED]>
Date: Wed, 10 Oct 2007 11:56:23 +0200
> Yep, that's exactly I'm talking about. I'm sure that
> [...] % (high - low) [...] erroneous from the begining, because
> in such places we want to have 1 in denominator, for the cases when we
> have only one port.
David Miller <[EMAIL PROTECTED]> writes:
>> Ok, I've got it, so we have to do the same with the following:
>> quote from inet_hashtables.c and inet6_hashtables.c. I'll prepare the
>> patch.
>>
>> And just a curious, does the /* Treat low > high as high == low */
>> idea will keep after the sysctl
From: Anton Arapov <[EMAIL PROTECTED]>
Date: Wed, 10 Oct 2007 11:00:17 +0200
> Ok, I've got it, so we have to do the same with the following:
> quote from inet_hashtables.c and inet6_hashtables.c. I'll prepare the
> patch.
>
> And just a curious, does the /* Treat low > high as high == low */
> i
Ok, I've got it, so we have to do the same with the following:
quote from inet_hashtables.c and inet6_hashtables.c. I'll prepare the
patch.
And just a curious, does the /* Treat low > high as high == low */
idea will keep after the sysctl will be patched?
int inet_hash_connect(struct inet_timewa
This patch fixed a possible division-by-zero in inet_csk_get_port
treating situation low > high as if low == high.
Signed-off-by: Denis V. Lunev <[EMAIL PROTECTED]>
CC: Antov Arapov <[EMAIL PROTECTED]>
--- ./net/ipv4/inet_connection_sock.c.getport 2007-10-09 15:16:02.0
+0400
+++ ./net
