Re: [PATCH] e1000: Work around 82571 completion timout on Pseries HW

2007-06-23 Thread Kok, Auke
Christoph Hellwig wrote: On Thu, May 17, 2007 at 09:58:03AM -0500, Wen Xiong wrote: It really shouldn't be there at all because something in either the intel or pseries hardware is totally buggy and we should disable features in the buggy one completely. Hi, Here there are not hardware issue

Re: [PATCH] e1000: Work around 82571 completion timout on Pseries HW

2007-06-23 Thread Christoph Hellwig
On Thu, May 17, 2007 at 09:58:03AM -0500, Wen Xiong wrote: > >>It really shouldn't be there at all because something in either the > intel > >>or pseries hardware is totally buggy and we should disable features in > >>the buggy one completely. > > Hi, > > Here there are not hardware issue on bot

Re: [PATCH] e1000: Work around 82571 completion timout on Pseries HW

2007-05-17 Thread Jeff Garzik
Auke Kok wrote: Our 82571 (first PCI-E hardware) causes P-Series hardware to throw issues. Disabling PCI-E completion timeouts in our NIC resolves the issue. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> Cc: Wen Xiong <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c | 10 ++ 1 fi

Re: [PATCH] e1000: Work around 82571 completion timout on Pseries HW

2007-05-17 Thread wendy xiong
On Thu, 2007-05-17 at 17:04 -0400, Jeff Garzik wrote: > Wen Xiong wrote: > > Here there are not hardware issue on both Intel or PPC. The patch is to > > work around a loop hold on early version of PCI SGI spec. > > The later PCI Sgi have spec have corrected it. We can just implement it > > fo

Re: [PATCH] e1000: Work around 82571 completion timout on Pseries HW

2007-05-17 Thread Jeff Garzik
Wen Xiong wrote: Here there are not hardware issue on both Intel or PPC. The patch is to work around a loop hold on early version of PCI SGI spec. The later PCI Sgi have spec have corrected it. We can just implement it for PPC only. Other vendor may have the same issue. If it is not a PP

Re: [PATCH] e1000: Work around 82571 completion timout on Pseries HW

2007-05-17 Thread Kumar Gala
On May 17, 2007, at 4:01 AM, Christoph Hellwig wrote: On Wed, May 16, 2007 at 07:43:27PM -0500, Kumar Gala wrote: index 49be393..830d851 100644 --- a/drivers/net/e1000/e1000_main.c +++ b/drivers/net/e1000/e1000_main.c @@ -819,6 +819,16 @@ e1000_reset(struct e1000_adapter *adapter)

Re: [PATCH] e1000: Work around 82571 completion timout on Pseries HW

2007-05-17 Thread Christoph Hellwig
On Wed, May 16, 2007 at 07:43:27PM -0500, Kumar Gala wrote: > >index 49be393..830d851 100644 > >--- a/drivers/net/e1000/e1000_main.c > >+++ b/drivers/net/e1000/e1000_main.c > >@@ -819,6 +819,16 @@ e1000_reset(struct e1000_adapter *adapter) > > E1000_WRITE_REG(&adapter->hw, CTRL, ctrl);

Re: [PATCH] e1000: Work around 82571 completion timout on Pseries HW

2007-05-16 Thread Kumar Gala
On May 16, 2007, at 3:53 AM, Auke Kok wrote: Our 82571 (first PCI-E hardware) causes P-Series hardware to throw issues. Disabling PCI-E completion timeouts in our NIC resolves the issue. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> Cc: Wen Xiong <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000

Re: [PATCH] e1000: Work around 82571 completion timout on Pseries HW

2007-05-16 Thread Benjamin Herrenschmidt
On Wed, 2007-05-16 at 17:11 -0500, Wen Xiong wrote: > little history, on PCI-X adapters we did not time dma reads being > returned to the adapter. On PCIe unfortunately the spec says that > adapters need to time the dma reads the spec is not specific on the > range but the timers can range from wo

Re: [PATCH] e1000: Work around 82571 completion timout on Pseries HW

2007-05-16 Thread Jeff Garzik
Auke Kok wrote: Our 82571 (first PCI-E hardware) causes P-Series hardware to throw issues. Disabling PCI-E completion timeouts in our NIC resolves the issue. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> Cc: Wen Xiong <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c | 10 ++ 1 fi

[PATCH] e1000: Work around 82571 completion timout on Pseries HW

2007-05-16 Thread Auke Kok
Our 82571 (first PCI-E hardware) causes P-Series hardware to throw issues. Disabling PCI-E completion timeouts in our NIC resolves the issue. Signed-off-by: Auke Kok <[EMAIL PROTECTED]> Cc: Wen Xiong <[EMAIL PROTECTED]> --- drivers/net/e1000/e1000_main.c | 10 ++ 1 files changed, 10 in