Re: [PATCH] esp4: remove redundant initialization of pointer esph

2018-02-14 Thread Steffen Klassert
On Fri, Feb 02, 2018 at 08:37:50AM +0100, Steffen Klassert wrote: > On Tue, Jan 30, 2018 at 02:53:48PM +, Colin King wrote: > > From: Colin Ian King > > > > Pointer esph is being assigned a value that is never read, esph is > > re-assigned and only read inside an if

Re: [PATCH] esp4: remove redundant initialization of pointer esph

2018-02-01 Thread Steffen Klassert
On Tue, Jan 30, 2018 at 02:53:48PM +, Colin King wrote: > From: Colin Ian King > > Pointer esph is being assigned a value that is never read, esph is > re-assigned and only read inside an if statement, hence the > initialization is redundant and can be removed. > >

[PATCH] esp4: remove redundant initialization of pointer esph

2018-01-30 Thread Colin King
From: Colin Ian King Pointer esph is being assigned a value that is never read, esph is re-assigned and only read inside an if statement, hence the initialization is redundant and can be removed. Cleans up clang warning: net/ipv4/esp4.c:657:21: warning: Value stored to