Re: [PATCH] ethernet/sfc: mark state UNINIT after unregister

2015-06-15 Thread Edward Cree
On 12/06/15 19:51, Jarod Wilson wrote: Without this change, modprobe -r sfc hits the BUG_ON() in efx_pci_remove_main(). Best as I can tell, this was just an oversight, efx-state gets set to STATE_UNINIT in the error path of efx_register_netdev() just after unregister_netdevice(), and the same

Re: [PATCH] ethernet/sfc: mark state UNINIT after unregister

2015-06-15 Thread Jarod Wilson
On 6/15/2015 9:49 AM, Edward Cree wrote: On 12/06/15 19:51, Jarod Wilson wrote: Without this change, modprobe -r sfc hits the BUG_ON() in efx_pci_remove_main(). Best as I can tell, this was just an oversight, efx-state gets set to STATE_UNINIT in the error path of efx_register_netdev() just

[PATCH] ethernet/sfc: mark state UNINIT after unregister

2015-06-12 Thread Jarod Wilson
Without this change, modprobe -r sfc hits the BUG_ON() in efx_pci_remove_main(). Best as I can tell, this was just an oversight, efx-state gets set to STATE_UNINIT in the error path of efx_register_netdev() just after unregister_netdevice(), and the same should happen in efx_unregister_netdev()