Re: [PATCH] fix memory leak in net/ipv4/tcp_probe.c::tcpprobe_read()

2006-08-10 Thread David Miller
From: Stephen Hemminger <[EMAIL PROTECTED]> Date: Thu, 10 Aug 2006 16:52:16 -0700 > Dave, here is my version... > Don't leak memory on interrupted read. And only allocate > as much memory as needed. > > Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> I think I'm going to go with James's saf

Re: [PATCH] fix memory leak in net/ipv4/tcp_probe.c::tcpprobe_read()

2006-08-10 Thread Stephen Hemminger
Dave, here is my version... Don't leak memory on interrupted read. And only allocate as much memory as needed. Signed-off-by: Stephen Hemminger <[EMAIL PROTECTED]> --- linux-2.6.orig/net/ipv4/tcp_probe.c 2006-08-10 16:32:36.0 -0700 +++ linux-2.6/net/ipv4/tcp_probe.c 2006-08-10 16:45

Re: [PATCH] fix memory leak in net/ipv4/tcp_probe.c::tcpprobe_read()

2006-08-10 Thread David Miller
From: "Jesper Juhl" <[EMAIL PROTECTED]> Date: Fri, 11 Aug 2006 00:18:44 +0200 > Hmm, perhaps I'm going blind, but I don't see it. I definitely screwed that changeset up somehow. Thanks for catching this. Somehow James's fix got clobbered into just my subsequent warning fix, like this: commit 1

Re: [PATCH] fix memory leak in net/ipv4/tcp_probe.c::tcpprobe_read()

2006-08-10 Thread Jesper Juhl
On 05/08/06, David Miller <[EMAIL PROTECTED]> wrote: From: "Jesper Juhl" <[EMAIL PROTECTED]> Date: Sat, 5 Aug 2006 01:30:49 +0200 > On 31/07/06, David Miller <[EMAIL PROTECTED]> wrote: > > From: "Jesper Juhl" <[EMAIL PROTECTED]> > > Date: Sun, 30 Jul 2006 23:51:20 +0200 > > > > > Looks ok to me.

Re: [PATCH] fix memory leak in net/ipv4/tcp_probe.c::tcpprobe_read()

2006-08-04 Thread David Miller
From: "Jesper Juhl" <[EMAIL PROTECTED]> Date: Sat, 5 Aug 2006 01:30:49 +0200 > On 31/07/06, David Miller <[EMAIL PROTECTED]> wrote: > > From: "Jesper Juhl" <[EMAIL PROTECTED]> > > Date: Sun, 30 Jul 2006 23:51:20 +0200 > > > > > Looks ok to me. > > > > I've applied James's version of the fix, thank

Re: [PATCH] fix memory leak in net/ipv4/tcp_probe.c::tcpprobe_read()

2006-08-04 Thread Jesper Juhl
On 31/07/06, David Miller <[EMAIL PROTECTED]> wrote: From: "Jesper Juhl" <[EMAIL PROTECTED]> Date: Sun, 30 Jul 2006 23:51:20 +0200 > Looks ok to me. I've applied James's version of the fix, thanks everyone. Hmm, if you are refering to commit 118075b3cdc90e0815362365f3fc64d672ace0d6 - http://w

Re: [PATCH] fix memory leak in net/ipv4/tcp_probe.c::tcpprobe_read()

2006-07-30 Thread David Miller
From: "Jesper Juhl" <[EMAIL PROTECTED]> Date: Sun, 30 Jul 2006 23:51:20 +0200 > Looks ok to me. I've applied James's version of the fix, thanks everyone. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http:

Re: [PATCH] fix memory leak in net/ipv4/tcp_probe.c::tcpprobe_read()

2006-07-30 Thread Jesper Juhl
On 30/07/06, James Morris <[EMAIL PROTECTED]> wrote: On Sun, 30 Jul 2006, Stephen Hemminger wrote: > On Sun, 30 Jul 2006 21:38:02 +0200 > Jesper Juhl <[EMAIL PROTECTED]> wrote: > > > There's an obvious memory leak in net/ipv4/tcp_probe.c::tcpprobe_read() > > We are not freeing 'tbuf' on error. >

Re: [PATCH] fix memory leak in net/ipv4/tcp_probe.c::tcpprobe_read()

2006-07-30 Thread James Morris
On Sun, 30 Jul 2006, Stephen Hemminger wrote: > On Sun, 30 Jul 2006 21:38:02 +0200 > Jesper Juhl <[EMAIL PROTECTED]> wrote: > > > There's an obvious memory leak in net/ipv4/tcp_probe.c::tcpprobe_read() > > We are not freeing 'tbuf' on error. > > Patch below fixes that. > > > > > > Signed-off-by

Re: [PATCH] fix memory leak in net/ipv4/tcp_probe.c::tcpprobe_read()

2006-07-30 Thread Stephen Hemminger
On Sun, 30 Jul 2006 21:38:02 +0200 Jesper Juhl <[EMAIL PROTECTED]> wrote: > There's an obvious memory leak in net/ipv4/tcp_probe.c::tcpprobe_read() > We are not freeing 'tbuf' on error. > Patch below fixes that. > > > Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> Agreed, thanks for catching it.

[PATCH] fix memory leak in net/ipv4/tcp_probe.c::tcpprobe_read()

2006-07-30 Thread Jesper Juhl
There's an obvious memory leak in net/ipv4/tcp_probe.c::tcpprobe_read() We are not freeing 'tbuf' on error. Patch below fixes that. Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> --- net/ipv4/tcp_probe.c |4 +++- 1 files changed, 3 insertions(+), 1 deletion(-) --- linux-2.6.18-rc3-orig/net