Re: [PATCH] gianfar: Add I/O barriers when touching buffer descriptor ownership.

2007-05-17 Thread Jeff Garzik
Scott Wood wrote: The hardware must not see that is given ownership of a buffer until it is completely written, and when the driver receives ownership of a buffer, it must ensure that any other reads to the buffer reflect its final state. Thus, I/O barriers are added where required. Without

[PATCH] gianfar: Add I/O barriers when touching buffer descriptor ownership.

2007-05-16 Thread Scott Wood
The hardware must not see that is given ownership of a buffer until it is completely written, and when the driver receives ownership of a buffer, it must ensure that any other reads to the buffer reflect its final state. Thus, I/O barriers are added where required. Without this patch, I have

Re: [PATCH] gianfar: Add I/O barriers when touching buffer descriptor ownership.

2007-05-02 Thread Scott Wood
Segher Boessenkool wrote: The hardware must not see that is given ownership of a buffer until it is completely written, and when the driver receives ownership of a buffer, it must ensure that any other reads to the buffer reflect its final state. Thus, I/O barriers are added where required.

Re: [PATCH] gianfar: Add I/O barriers when touching buffer descriptor ownership.

2007-05-02 Thread Segher Boessenkool
AFAICS you need stronger barriers though; {w,r,}mb(), to prevent _any_ reordering of those memory accesses, not just the compiler-generated ones. My impression was that the eieio used by iobarrier would be sufficient for that, as we're not trying to synchronize between accesses to different

[PATCH] gianfar: Add I/O barriers when touching buffer descriptor ownership.

2007-05-01 Thread Scott Wood
The hardware must not see that is given ownership of a buffer until it is completely written, and when the driver receives ownership of a buffer, it must ensure that any other reads to the buffer reflect its final state. Thus, I/O barriers are added where required. Without this patch, I have

Re: [PATCH] gianfar: Add I/O barriers when touching buffer descriptor ownership.

2007-05-01 Thread Segher Boessenkool
The hardware must not see that is given ownership of a buffer until it is completely written, and when the driver receives ownership of a buffer, it must ensure that any other reads to the buffer reflect its final state. Thus, I/O barriers are added where required. Without this patch, I have