RE: [PATCH] lan78xx: Connect phy early

2018-03-15 Thread Nisar.Sayed
Hi Alexander, Thanks for the patch. > @@ -2575,13 +2571,7 @@ static int lan78xx_stop(struct net_device *net) > if (timer_pending(>stat_monitor)) > del_timer_sync(>stat_monitor); > > - phy_unregister_fixup_for_uid(PHY_KSZ9031RNX, 0xfff0); > -

Re: [PATCH] lan78xx: Connect phy early

2018-03-14 Thread Andrew Lunn
> @@ -2082,8 +2082,6 @@ static int lan78xx_phy_init(struct lan78xx_net *dev) > > dev->fc_autoneg = phydev->autoneg; > > - phy_start(phydev); > - > netif_dbg(dev, ifup, dev->net, "phy initialised successfully"); > > return 0; > @@ -2512,9 +2510,7 @@ static int

RE: [PATCH] lan78xx: Connect phy early

2018-03-14 Thread Woojung.Huh
699 <woojung@microchip.com> > Cc: UNGLinuxDriver <unglinuxdri...@microchip.com>; netdev@vger.kernel.org; > linux- > u...@vger.kernel.org; linux-ker...@vger.kernel.org; Thomas Bogendoerfer > <tbogendoer...@suse.de>; Phil Elwell <p...@raspberrypi.org> > Subject: [PATCH

[PATCH] lan78xx: Connect phy early

2018-03-14 Thread Alexander Graf
When using wicked with a lan78xx device attached to the system, we end up with ethtool commands issued on the device before an ifup got issued. That lead to the following crash: Unable to handle kernel NULL pointer dereference at virtual address 039c pgd = 800035b3