Re: [PATCH] libertas: Don't mark exported symbols as static

2008-02-09 Thread Dan Williams
On Fri, 2008-02-08 at 23:48 -0500, Christoph Hellwig wrote: > On Fri, Feb 08, 2008 at 06:01:02PM -0800, Roland Dreier wrote: > > > Why not pull the exports? they aren't used anywhere in the existing > > kernel. > > > > I'm guessing there's some not-(yet-)merged mesh networking stuff that > > use

Re: [PATCH] libertas: Don't mark exported symbols as static

2008-02-08 Thread Christoph Hellwig
On Fri, Feb 08, 2008 at 06:01:02PM -0800, Roland Dreier wrote: > > Why not pull the exports? they aren't used anywhere in the existing kernel. > > I'm guessing there's some not-(yet-)merged mesh networking stuff that > uses the symbols, but it doesn't matter much to me... The general rule is to

Re: [PATCH] libertas: Don't mark exported symbols as static

2008-02-08 Thread Roland Dreier
> Why not pull the exports? they aren't used anywhere in the existing kernel. I'm guessing there's some not-(yet-)merged mesh networking stuff that uses the symbols, but it doesn't matter much to me... - R. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a me

Re: [PATCH] libertas: Don't mark exported symbols as static

2008-02-08 Thread Stephen Hemminger
On Fri, 08 Feb 2008 16:07:26 -0800 Roland Dreier <[EMAIL PROTECTED]> wrote: > Marking exported symbols as static causes the following build error on > ia64 with gcc 4.2.3: > > drivers/net/wireless/libertas/main.c:1375: error: __ksymtab_lbs_remove_mesh > causes a section type conflict > drivers/n

[PATCH] libertas: Don't mark exported symbols as static

2008-02-08 Thread Roland Dreier
Marking exported symbols as static causes the following build error on ia64 with gcc 4.2.3: drivers/net/wireless/libertas/main.c:1375: error: __ksymtab_lbs_remove_mesh causes a section type conflict drivers/net/wireless/libertas/main.c:1354: error: __ksymtab_lbs_add_mesh causes a section type co