Re: [PATCH] mISDN: use kstrdup() in dsp_pipeline_build

2015-10-10 Thread Joe Perches
On Sat, 2015-10-10 at 02:32 -0700, Geliang Tang wrote: > Use kstrdup instead of strlen-kmalloc-strcpy. Not the same code. Instead of returning early, a 0 length string will now set pipeline->inuse to 0. Maybe that's OK, but you should state why in the commit log. > diff --git

[PATCH] mISDN: use kstrdup() in dsp_pipeline_build

2015-10-10 Thread Geliang Tang
Use kstrdup instead of strlen-kmalloc-strcpy. Signed-off-by: Geliang Tang --- drivers/isdn/mISDN/dsp_pipeline.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/isdn/mISDN/dsp_pipeline.c b/drivers/isdn/mISDN/dsp_pipeline.c index