Re: [PATCH] net: Add 405EX support to new EMAC driver

2007-11-05 Thread Stefan Roese
On Monday 05 November 2007, Benjamin Herrenschmidt wrote: > > So how exactly do you want me to handle this (I'm still new to this > > device > > tree stuff, so please bear with me)? Like this? > > > > RGMII0: [EMAIL PROTECTED] { > > device_typ

Re: [PATCH] net: Add 405EX support to new EMAC driver

2007-11-05 Thread Benjamin Herrenschmidt
On Mon, 2007-11-05 at 10:19 +0100, Stefan Roese wrote: > > > Somewhat yeah. There are subtle variations here or there we haven't > > totally indenfified... It might be a better option in our case here > to > > add "has-mdio" to the rgmii nodes indeed. > > So how exactly do you want me to handle

Re: [PATCH] net: Add 405EX support to new EMAC driver

2007-11-05 Thread Stefan Roese
On Sunday 04 November 2007, Benjamin Herrenschmidt wrote: > > Isn't this the case where there should really be device tree properties > > instead? If you had an "ibm,emac-has-axon-stacr" property in the device > > node, then you don't have to modify the driver for every new board out > > there. Sam

Re: [PATCH] net: Add 405EX support to new EMAC driver

2007-11-04 Thread Olof Johansson
On Sun, Nov 04, 2007 at 02:37:59PM +1100, Benjamin Herrenschmidt wrote: > > On Fri, 2007-11-02 at 11:03 -0500, Olof Johansson wrote: > > On Fri, Nov 02, 2007 at 08:14:43AM +0100, Stefan Roese wrote: > > > This patch adds support for the 405EX to the new EMAC driver. Some as on > > > AXON, the 405E

Re: [PATCH] net: Add 405EX support to new EMAC driver

2007-11-03 Thread Benjamin Herrenschmidt
On Fri, 2007-11-02 at 11:03 -0500, Olof Johansson wrote: > On Fri, Nov 02, 2007 at 08:14:43AM +0100, Stefan Roese wrote: > > This patch adds support for the 405EX to the new EMAC driver. Some as on > > AXON, the 405EX handles the MDIO via the RGMII bridge. > > Hi, > > This isn't feedback on your

Re: [PATCH] net: Add 405EX support to new EMAC driver

2007-11-02 Thread Olof Johansson
On Fri, Nov 02, 2007 at 08:14:43AM +0100, Stefan Roese wrote: > This patch adds support for the 405EX to the new EMAC driver. Some as on > AXON, the 405EX handles the MDIO via the RGMII bridge. Hi, This isn't feedback on your patch as much as on "new-emac" in general: Isn't this the case where t

[PATCH] net: Add 405EX support to new EMAC driver

2007-11-01 Thread Stefan Roese
This patch adds support for the 405EX to the new EMAC driver. Some as on AXON, the 405EX handles the MDIO via the RGMII bridge. Tested on AMCC Kilauea. Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/core.c |3 ++- drivers/net/ibm_newemac/rgmii.c | 16 +

Re: [PATCH] net: Add 405EX support to new EMAC driver

2007-11-01 Thread Stefan Roese
On Thursday 01 November 2007, Josh Boyer wrote: > > > - if (dev->type != RGMII_AXON) > > > - return; > > > - > > > mutex_lock(&dev->lock); > > > > That will break 440GX boards that need to use the RGMII for data and the > > ZMII for MDIO. > > > > You may want to change the name RGMII_AXON

Re: [PATCH] net: Add 405EX support to new EMAC driver

2007-11-01 Thread Josh Boyer
On Fri, 02 Nov 2007 07:37:01 +1100 Benjamin Herrenschmidt <[EMAIL PROTECTED]> wrote: > > On Thu, 2007-11-01 at 15:54 +0100, Stefan Roese wrote: > > This patch adds support for the 405EX to the new EMAC driver. > > > > Tested on AMCC Kilauea. > > .../... > > > diff --git a/drivers/net/ibm_newe

Re: [PATCH] net: Add 405EX support to new EMAC driver

2007-11-01 Thread Benjamin Herrenschmidt
On Thu, 2007-11-01 at 15:54 +0100, Stefan Roese wrote: > This patch adds support for the 405EX to the new EMAC driver. > > Tested on AMCC Kilauea. .../... > diff --git a/drivers/net/ibm_newemac/rgmii.c b/drivers/net/ibm_newemac/rgmii.c > index de41695..e393f68 100644 > --- a/drivers/net/ibm_ne

[PATCH] net: Add 405EX support to new EMAC driver

2007-11-01 Thread Stefan Roese
This patch adds support for the 405EX to the new EMAC driver. Tested on AMCC Kilauea. Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> --- drivers/net/ibm_newemac/core.c |3 ++- drivers/net/ibm_newemac/rgmii.c |6 -- 2 files changed, 2 insertions(+), 7 deletions(-) diff --git a/driv