Re: [PATCH] net: diag: Tell user if support for destroying TCP sockets is not enabled

2016-05-16 Thread David Ahern
On 5/16/16 6:49 PM, Lorenzo Colitti wrote: On Tue, May 17, 2016 at 8:53 AM, David Ahern wrote: +#else +static int tcp_diag_destroy(struct sk_buff *in_skb, + const struct inet_diag_req_v2 *req) +{ + return -EOPNOTSUPP; +} #endif I

Re: [PATCH] net: diag: Tell user if support for destroying TCP sockets is not enabled

2016-05-16 Thread Lorenzo Colitti
On Tue, May 17, 2016 at 8:53 AM, David Ahern wrote: > +#else > +static int tcp_diag_destroy(struct sk_buff *in_skb, > + const struct inet_diag_req_v2 *req) > +{ > + return -EOPNOTSUPP; > +} > #endif I don't understand why you need this.

[PATCH] net: diag: Tell user if support for destroying TCP sockets is not enabled

2016-05-16 Thread David Ahern
Commit c1e64e298b8c added support for destroying TCP sockets but it is wrapped in a config option. If the option is not enabled the user is given no feedback and ss for example just exits 0 which is not a friendly UI: $ ss -4 state established sport = :22 Netid Recv-Q Send-Q Local