Re: [PATCH] net: dsa: properly disconnect the slave PHYs

2016-10-18 Thread John Crispin
On 18/10/2016 15:24, Andrew Lunn wrote: >> Hi Andrew >> >> i am testing on v4.4 which did not have a phy_disconnect() call. this >> seems to have been fixed by cda5c15b so please ignore this patch > > Hi John > > All patches must be against net-next, or net if it is a fix. Anything > else is wr

Re: [PATCH] net: dsa: properly disconnect the slave PHYs

2016-10-18 Thread Andrew Lunn
> Hi Andrew > > i am testing on v4.4 which did not have a phy_disconnect() call. this > seems to have been fixed by cda5c15b so please ignore this patch Hi John All patches must be against net-next, or net if it is a fix. Anything else is wrong Andrew

Re: [PATCH] net: dsa: properly disconnect the slave PHYs

2016-10-18 Thread John Crispin
On 18/10/2016 14:29, Andrew Lunn wrote: > On Tue, Oct 18, 2016 at 02:12:40PM +0200, John Crispin wrote: >> The shutdown code only stopped the PHYs but does not diconnect them >> properly. This could lead to null pointer deref related kernel oopses >> during reboot. Fix this by calling phy_disconn

Re: [PATCH] net: dsa: properly disconnect the slave PHYs

2016-10-18 Thread Andrew Lunn
On Tue, Oct 18, 2016 at 02:12:40PM +0200, John Crispin wrote: > The shutdown code only stopped the PHYs but does not diconnect them > properly. This could lead to null pointer deref related kernel oopses > during reboot. Fix this by calling phy_disconnect() after the PHYs are > stopped. Humm, i do

[PATCH] net: dsa: properly disconnect the slave PHYs

2016-10-18 Thread John Crispin
The shutdown code only stopped the PHYs but does not diconnect them properly. This could lead to null pointer deref related kernel oopses during reboot. Fix this by calling phy_disconnect() after the PHYs are stopped. Signed-off-by: John Crispin --- net/dsa/slave.c |4 +++- 1 file changed, 3