Re: [PATCH] net: ethernet: sun: niu set correct packet size in skb

2018-05-04 Thread David Miller
From: David Miller Date: Fri, 04 May 2018 13:09:50 -0400 (EDT) > From: Rob Taglang > Date: Fri, 04 May 2018 13:07:54 -0400 > >>> Still corrupted. Your email client is chopping up long lines. >>> Please, send a test patch to yourself and make sure you can apply the >>> patch that arrives in tha

Re: [PATCH] net: ethernet: sun: niu set correct packet size in skb

2018-05-04 Thread David Miller
From: Rob Taglang Date: Fri, 04 May 2018 13:07:54 -0400 >> Still corrupted. Your email client is chopping up long lines. >> Please, send a test patch to yourself and make sure you can apply the >> patch that arrives in that test email. >> Thank you. > > Hi David, > > I did go through the proce

Re: [PATCH] net: ethernet: sun: niu set correct packet size in skb

2018-05-04 Thread David Miller
From: Rob Taglang Date: Thu, 03 May 2018 17:13:06 -0400 > Currently, skb->len and skb->data_len are set to the page size, not > the packet size. This causes the frame check sequence to not be > located at the "end" of the packet resulting in ethernet frame check > errors. The driver does work cur

[PATCH] net: ethernet: sun: niu set correct packet size in skb

2018-05-03 Thread Rob Taglang
Currently, skb->len and skb->data_len are set to the page size, not the packet size. This causes the frame check sequence to not be located at the "end" of the packet resulting in ethernet frame check errors. The driver does work currently, but stricter kernel facing networking solutions like O

Re: [PATCH] net: ethernet: sun: niu set correct packet size in skb

2018-05-03 Thread David Miller
From: r...@taglang.io Date: Thu, 03 May 2018 16:38:04 -0400 > Ah, gotcha. Should I make a new thread? Yes, please do. Thank you.

Re: [PATCH] net: ethernet: sun: niu set correct packet size in skb

2018-05-03 Thread rob
Ah, gotcha. Should I make a new thread? Patch should be properly formatted below. Thanks, Rob Signed-off-by: Rob Taglang --- drivers/net/ethernet/sun/niu.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/ethernet/sun/niu.c b/drivers/net/ethernet/sun/niu.c

Re: [PATCH] net: ethernet: sun: niu set correct packet size in skb

2018-05-03 Thread David Miller
From: Rob Taglang Date: Thu, 03 May 2018 11:06:04 -0400 > Currently, skb->len and skb->data_len are set to the page size, not > the packet size. This causes the frame check sequence to not be > located at the "end" of the packet resulting in ethernet frame check > errors. The driver does work cur