Re: [PATCH] net: ethtool: remove error check for legacy setting transceiver type

2017-10-21 Thread David Miller
From: Niklas Söderlund Date: Fri, 20 Oct 2017 01:32:08 +0200 > Commit 9cab88726929605 ("net: ethtool: Add back transceiver type") > restores the transceiver type to struct ethtool_link_settings and > convert_link_ksettings_to_legacy_settings() but forgets

Re: [PATCH] net: ethtool: remove error check for legacy setting transceiver type

2017-10-20 Thread Niklas Söderlund
Hi Geert, On 2017-10-20 09:15:50 +0200, Geert Uytterhoeven wrote: > Hi Niklas, > > On Fri, Oct 20, 2017 at 1:32 AM, Niklas Söderlund > wrote: > > Commit 9cab88726929605 ("net: ethtool: Add back transceiver type") > > restores the transceiver type to struct

Re: [PATCH] net: ethtool: remove error check for legacy setting transceiver type

2017-10-20 Thread Niklas Söderlund
Hi Geert, On 2017-10-20 09:15:50 +0200, Geert Uytterhoeven wrote: > Hi Niklas, > > On Fri, Oct 20, 2017 at 1:32 AM, Niklas Söderlund > wrote: > > Commit 9cab88726929605 ("net: ethtool: Add back transceiver type") > > restores the transceiver type to struct

Re: [PATCH] net: ethtool: remove error check for legacy setting transceiver type

2017-10-20 Thread Geert Uytterhoeven
Hi Niklas, On Fri, Oct 20, 2017 at 1:32 AM, Niklas Söderlund wrote: > Commit 9cab88726929605 ("net: ethtool: Add back transceiver type") > restores the transceiver type to struct ethtool_link_settings and > convert_link_ksettings_to_legacy_settings() but

[PATCH] net: ethtool: remove error check for legacy setting transceiver type

2017-10-19 Thread Niklas Söderlund
Commit 9cab88726929605 ("net: ethtool: Add back transceiver type") restores the transceiver type to struct ethtool_link_settings and convert_link_ksettings_to_legacy_settings() but forgets to remove the error check for the same in convert_legacy_settings_to_link_ksettings(). This prevents older

Re: [PATCH] net: ethtool: remove error check for legacy setting transceiver type

2017-10-19 Thread Florian Fainelli
On 10/19/2017 04:32 PM, Niklas Söderlund wrote: > Commit 9cab88726929605 ("net: ethtool: Add back transceiver type") > restores the transceiver type to struct ethtool_link_settings and > convert_link_ksettings_to_legacy_settings() but forgets to remove the > error check for the same in