Re: [PATCH] net: fec: set dma_coherent_mask

2018-03-28 Thread Greg Ungerer
Hi Geert, On 28/03/18 17:57, Geert Uytterhoeven wrote: [skip] [PATCH] m68k: set dma and coherent masks for platform FEC ethernets As of commit 205e1b7f51e4 ("dma-mapping: warn when there is no coherent_dma_mask") the Freescale FEC driver is issuing the following warning on driver

Re: [PATCH] net: fec: set dma_coherent_mask

2018-03-28 Thread Geert Uytterhoeven
Hi Greg, On Wed, Mar 28, 2018 at 9:27 AM, Greg Ungerer wrote: > On 27/03/18 22:59, Geert Uytterhoeven wrote: >> On Mon, Mar 26, 2018 at 3:36 PM, Greg Ungerer wrote: >>> As of commit 205e1b7f51e4 ("dma-mapping: warn when there is no >>>

Re: [PATCH] net: fec: set dma_coherent_mask

2018-03-28 Thread Greg Ungerer
Hi Geert, On 27/03/18 22:59, Geert Uytterhoeven wrote: > On Mon, Mar 26, 2018 at 3:36 PM, Greg Ungerer wrote: >> As of commit 205e1b7f51e4 ("dma-mapping: warn when there is no >> coherent_dma_mask") the Freescale FEC driver is issuing the following >> warning on driver

RE: [PATCH] net: fec: set dma_coherent_mask

2018-03-28 Thread Andy Duan
From: Geert Uytterhoeven Sent: 2018年3月28日 15:07 > Hi Andy, > > On Wed, Mar 28, 2018 at 5:04 AM, Andy Duan wrote: > > From: Geert Uytterhoeven Sent: 2018年3月27日 > 20:59 > >> On Mon, Mar 26, 2018 at 3:36 PM, Greg Ungerer

Re: [PATCH] net: fec: set dma_coherent_mask

2018-03-28 Thread Geert Uytterhoeven
Hi Andy, On Wed, Mar 28, 2018 at 5:04 AM, Andy Duan wrote: > From: Geert Uytterhoeven Sent: 2018年3月27日 20:59 >> On Mon, Mar 26, 2018 at 3:36 PM, Greg Ungerer wrote: >> > As of commit 205e1b7f51e4 ("dma-mapping: warn when there is

RE: [PATCH] net: fec: set dma_coherent_mask

2018-03-27 Thread Andy Duan
From: Geert Uytterhoeven Sent: 2018年3月27日 20:59 > Hi Greg, > > On Mon, Mar 26, 2018 at 3:36 PM, Greg Ungerer wrote: > > As of commit 205e1b7f51e4 ("dma-mapping: warn when there is no > > coherent_dma_mask") the Freescale FEC driver is issuing the

Re: [PATCH] net: fec: set dma_coherent_mask

2018-03-27 Thread Lino Sanfilippo
Hi, > > + dma_set_coherent_mask(>pdev->dev, DMA_BIT_MASK(32)); > + > for (i = 0; i < fep->num_tx_queues; i++) { > txq = kzalloc(sizeof(*txq), GFP_KERNEL); > if (!txq) { dma_set_coherent_mask() can fail, so the return value should be checked and a failure

Re: [PATCH] net: fec: set dma_coherent_mask

2018-03-27 Thread Geert Uytterhoeven
Hi Greg, On Mon, Mar 26, 2018 at 3:36 PM, Greg Ungerer wrote: > As of commit 205e1b7f51e4 ("dma-mapping: warn when there is no > coherent_dma_mask") the Freescale FEC driver is issuing the following > warning on driver initialization on ColdFire systems: > > WARNING: CPU: 0

[PATCH] net: fec: set dma_coherent_mask

2018-03-26 Thread Greg Ungerer
As of commit 205e1b7f51e4 ("dma-mapping: warn when there is no coherent_dma_mask") the Freescale FEC driver is issuing the following warning on driver initialization on ColdFire systems: WARNING: CPU: 0 PID: 1 at ./include/linux/dma-mapping.h:516 0x40159e20 Modules linked in: CPU: 0 PID: 1 Comm: