Re: [PATCH] net: fec: turn on device when extracting statistics

2016-11-28 Thread David Miller
From: Nikita Yushchenko Date: Mon, 28 Nov 2016 10:06:31 +0300 > > > 28.11.2016 04:29, David Miller пишет: >> From: Nikita Yushchenko >> Date: Fri, 25 Nov 2016 13:02:00 +0300 >> >>> + int i, ret; >>> + >>> + ret =

Re: [PATCH] net: fec: turn on device when extracting statistics

2016-11-27 Thread Nikita Yushchenko
28.11.2016 04:29, David Miller пишет: > From: Nikita Yushchenko > Date: Fri, 25 Nov 2016 13:02:00 +0300 > >> +int i, ret; >> + >> +ret = pm_runtime_get_sync(>pdev->dev); >> +if (IS_ERR_VALUE(ret)) { >> +memset(data, 0, sizeof(*data) *

Re: [PATCH] net: fec: turn on device when extracting statistics

2016-11-27 Thread David Miller
From: Nikita Yushchenko Date: Fri, 25 Nov 2016 13:02:00 +0300 > + int i, ret; > + > + ret = pm_runtime_get_sync(>pdev->dev); > + if (IS_ERR_VALUE(ret)) { > + memset(data, 0, sizeof(*data) * ARRAY_SIZE(fec_stats)); > + return; >

RE: [PATCH] net: fec: turn on device when extracting statistics

2016-11-26 Thread Andy Duan
Eric Nelson <e...@nelint.com>; Philippe >Reynes <trem...@gmail.com>; Johannes Berg <johan...@sipsolutions.net>; >netdev@vger.kernel.org; linux-ker...@vger.kernel.org >Cc: Chris Healy <cphe...@gmail.com>; Nikita Yushchenko ><nikita.yo...@cogentembedd

[PATCH] net: fec: turn on device when extracting statistics

2016-11-25 Thread Nikita Yushchenko
Execution 'ethtool -S' on fec device that is down causes OOPS on Vybrid board: Unhandled fault: external abort on non-linefetch (0x1008) at 0xe0898200 pgd = ddecc000 [e0898200] *pgd=9e406811, *pte=400d1653, *ppte=400d1453 Internal error: : 1008 [#1] SMP ARM ... Reason of OOPS is that