Re: [PATCH] net: fix bogus cast in skb_pagelen() and use unsigned variables

2016-11-23 Thread Alexey Dobriyan
On Wed, Nov 23, 2016 at 3:49 PM, David Laight wrote: > From: Alexey Dobriyan >> Sent: 19 November 2016 01:08 > ... >> - for (i = (int)skb_shinfo(skb)->nr_frags - 1; i >= 0; i--) >> + for (i = skb_shinfo(skb)->nr_frags - 1; (int)i >= 0; i--) >> len +=

RE: [PATCH] net: fix bogus cast in skb_pagelen() and use unsigned variables

2016-11-23 Thread David Laight
From: Alexey Dobriyan > Sent: 19 November 2016 01:08 ... > - for (i = (int)skb_shinfo(skb)->nr_frags - 1; i >= 0; i--) > + for (i = skb_shinfo(skb)->nr_frags - 1; (int)i >= 0; i--) > len += skb_frag_size(_shinfo(skb)->frags[i]); Think I'd use: for (i =

Re: [PATCH] net: fix bogus cast in skb_pagelen() and use unsigned variables

2016-11-19 Thread David Miller
From: Alexey Dobriyan Date: Sat, 19 Nov 2016 04:08:08 +0300 > 1) cast to "int" is unnecessary: >u8 will be promoted to int before decrementing, >small positive numbers fit into "int", so their values won't be changed >during promotion. > >Once everything is

[PATCH] net: fix bogus cast in skb_pagelen() and use unsigned variables

2016-11-18 Thread Alexey Dobriyan
1) cast to "int" is unnecessary: u8 will be promoted to int before decrementing, small positive numbers fit into "int", so their values won't be changed during promotion. Once everything is int including loop counters, signedness doesn't matter: 32-bit operations will stay 32-bit