Re: [PATCH] net: hns: use put_device() if device_register fail

2018-03-12 Thread arvindY
On Monday 12 March 2018 10:59 PM, Richard Weinberger wrote: On Mon, Mar 12, 2018 at 5:27 PM, arvindY wrote: On Monday 12 March 2018 08:13 PM, David Miller wrote: From: Arvind Yadav Date: Fri, 9 Mar 2018 16:11:17 +0530 if

Re: [PATCH] net: hns: use put_device() if device_register fail

2018-03-12 Thread Richard Weinberger
On Mon, Mar 12, 2018 at 5:27 PM, arvindY wrote: > > > On Monday 12 March 2018 08:13 PM, David Miller wrote: >> >> From: Arvind Yadav >> Date: Fri, 9 Mar 2018 16:11:17 +0530 >> >>> if device_register() returned an error! Always use

Re: [PATCH] net: hns: use put_device() if device_register fail

2018-03-12 Thread arvindY
On Monday 12 March 2018 08:13 PM, David Miller wrote: From: Arvind Yadav Date: Fri, 9 Mar 2018 16:11:17 +0530 if device_register() returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav

Re: [PATCH] net: hns: use put_device() if device_register fail

2018-03-12 Thread David Miller
From: Arvind Yadav Date: Fri, 9 Mar 2018 16:11:17 +0530 > if device_register() returned an error! Always use put_device() > to give up the reference initialized. > > Signed-off-by: Arvind Yadav I do not see anything giving cls_dev an

[PATCH] net: hns: use put_device() if device_register fail

2018-03-09 Thread Arvind Yadav
if device_register() returned an error! Always use put_device() to give up the reference initialized. Signed-off-by: Arvind Yadav --- drivers/net/ethernet/hisilicon/hns/hnae.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git