Re: [PATCH] net: ipv6: fix regression of no RTM_DELADDR sent after DAD failure

2017-09-19 Thread David Miller
From: Mike Manning Date: Mon, 18 Sep 2017 14:06:40 +0100 > In the absence of a reply from Mahesh, I would be most grateful for > anyone familiar with the IPv6 code to review this 1-line fix. > > Or if not, then I request that the commit f784ad3d79e5 is backed out, > as its intention is to remove

Re: [PATCH] net: ipv6: fix regression of no RTM_DELADDR sent after DAD failure

2017-09-18 Thread Mike Manning
Hi, In the absence of a reply from Mahesh, I would be most grateful for anyone familiar with the IPv6 code to review this 1-line fix. Or if not, then I request that the commit f784ad3d79e5 is backed out, as its intention is to remove the redundant but harmless RTM_DELADDR for addresses in tentativ

Re: [PATCH] net: ipv6: fix regression of no RTM_DELADDR sent after DAD failure

2017-09-07 Thread David Miller
From: Mike Manning Date: Mon, 4 Sep 2017 15:52:55 +0100 > Commit f784ad3d79e5 ("ipv6: do not send RTM_DELADDR for tentative > addresses") incorrectly assumes that no RTM_NEWADDR are sent for > addresses in tentative state, as this does happen for the standard > IPv6 use-case of DAD failure, see

[PATCH] net: ipv6: fix regression of no RTM_DELADDR sent after DAD failure

2017-09-04 Thread Mike Manning
Commit f784ad3d79e5 ("ipv6: do not send RTM_DELADDR for tentative addresses") incorrectly assumes that no RTM_NEWADDR are sent for addresses in tentative state, as this does happen for the standard IPv6 use-case of DAD failure, see the call to ipv6_ifa_notify() in addconf_dad_stop(). So as a result