Forwarded message --
> Date: Thu, 5 Oct 2017 21:38:28 +0800
> From: kbuild test robot <fengguang...@intel.com>
> To: kbu...@01.org
> Cc: Julia Lawall <julia.law...@lip6.fr>
> Subject: Re: [PATCH] net: phy: DP83822 initial driver submission
>
> CC: kbuild-...@01.org
&g
Subject: Re: [PATCH] net: phy: DP83822 initial driver submission
CC: kbuild-...@01.org
In-Reply-To: <20171003155316.12312-1-dmur...@ti.com>
TO: Dan Murphy <dmur...@ti.com>
CC: and...@lunn.ch, f.faine...@gmail.com, netdev@vger.kernel.org, Dan Murphy
<dmur...@ti.com>
CC: netdev@vge
On 10/04/2017 08:41 AM, Dan Murphy wrote:
> Florian
>
> On 10/03/2017 01:31 PM, Florian Fainelli wrote:
>> On 10/03/2017 11:03 AM, Dan Murphy wrote:
>>> Florian
>>>
>>> Thanks for the review
>>>
>>> On 10/03/2017 12:15 PM, Florian Fainelli wrote:
> + } else {
> +
Florian
On 10/04/2017 11:18 AM, Florian Fainelli wrote:
> On 10/04/2017 08:41 AM, Dan Murphy wrote:
>> Florian
>>
>> On 10/03/2017 01:31 PM, Florian Fainelli wrote:
>>> On 10/03/2017 11:03 AM, Dan Murphy wrote:
Florian
Thanks for the review
On 10/03/2017 12:15 PM, Florian
Florian
On 10/03/2017 01:31 PM, Florian Fainelli wrote:
> On 10/03/2017 11:03 AM, Dan Murphy wrote:
>> Florian
>>
>> Thanks for the review
>>
>> On 10/03/2017 12:15 PM, Florian Fainelli wrote:
+ } else {
+ value &= ~DP83822_WOL_SECURE_ON;
+ }
On 10/03/2017 11:03 AM, Dan Murphy wrote:
> Florian
>
> Thanks for the review
>
> On 10/03/2017 12:15 PM, Florian Fainelli wrote:
>>> + } else {
>>> + value &= ~DP83822_WOL_SECURE_ON;
>>> + }
>>> +
>>> + value |= (DP83822_WOL_EN |
Florian
Thanks for the review
On 10/03/2017 12:15 PM, Florian Fainelli wrote:
> On 10/03/2017 08:53 AM, Dan Murphy wrote:
>> Add support for the TI DP83822 10/100Mbit ethernet phy.
>>
>> The DP83822 provides flexibility to connect to a MAC through a
>> standard MII, RMII or RGMII interface.
>>
> +static int dp83822_suspend(struct phy_device *phydev)
> +{
> + int value;
> +
> + mutex_lock(>lock);
> +
> + value = phy_read_mmd(phydev, DP83822_DEVADDR,
> MII_DP83822_WOL_CFG);
> + if (~value & DP83822_WOL_EN) {
Same result, but how about " if (!(value & DP83822_WOL_EN))" ?
>
On 10/03/2017 08:53 AM, Dan Murphy wrote:
> Add support for the TI DP83822 10/100Mbit ethernet phy.
>
> The DP83822 provides flexibility to connect to a MAC through a
> standard MII, RMII or RGMII interface.
>
> Datasheet:
> http://www.ti.com/product/DP83822I/datasheet
This looks pretty good,
All
On 10/03/2017 10:53 AM, Dan Murphy wrote:
> Add support for the TI DP83822 10/100Mbit ethernet phy.
>
> The DP83822 provides flexibility to connect to a MAC through a
> standard MII, RMII or RGMII interface.
>
I need to submit an additional patch to remove DP83822 from the DP83848.
The
Add support for the TI DP83822 10/100Mbit ethernet phy.
The DP83822 provides flexibility to connect to a MAC through a
standard MII, RMII or RGMII interface.
Datasheet:
http://www.ti.com/product/DP83822I/datasheet
Signed-off-by: Dan Murphy
---
drivers/net/phy/Kconfig | 5
11 matches
Mail list logo