Re: [PATCH] netfilter: ctnetlink: add more #ifdef around unused code

2016-04-18 Thread Pablo Neira Ayuso
On Mon, Apr 18, 2016 at 10:04:43PM +0200, Arnd Bergmann wrote: > On Monday 18 April 2016 20:43:36 Pablo Neira Ayuso wrote: > > On Mon, Apr 18, 2016 at 08:33:15PM +0200, Arnd Bergmann wrote: > > > On Monday 18 April 2016 20:16:59 Pablo Neira Ayuso wrote: > > > > On Sat, Apr 16, 2016 at 10:17:43PM

Re: [PATCH] netfilter: ctnetlink: add more #ifdef around unused code

2016-04-18 Thread Arnd Bergmann
On Monday 18 April 2016 20:43:36 Pablo Neira Ayuso wrote: > On Mon, Apr 18, 2016 at 08:33:15PM +0200, Arnd Bergmann wrote: > > On Monday 18 April 2016 20:16:59 Pablo Neira Ayuso wrote: > > > On Sat, Apr 16, 2016 at 10:17:43PM +0200, Arnd Bergmann wrote: > > > > A recent patch removed many 'inline'

Re: [PATCH] netfilter: ctnetlink: add more #ifdef around unused code

2016-04-18 Thread Pablo Neira Ayuso
On Mon, Apr 18, 2016 at 08:33:15PM +0200, Arnd Bergmann wrote: > On Monday 18 April 2016 20:16:59 Pablo Neira Ayuso wrote: > > On Sat, Apr 16, 2016 at 10:17:43PM +0200, Arnd Bergmann wrote: > > > A recent patch removed many 'inline' annotations for static > > > functions in this file, which has

Re: [PATCH] netfilter: ctnetlink: add more #ifdef around unused code

2016-04-18 Thread Arnd Bergmann
On Monday 18 April 2016 20:16:59 Pablo Neira Ayuso wrote: > On Sat, Apr 16, 2016 at 10:17:43PM +0200, Arnd Bergmann wrote: > > A recent patch removed many 'inline' annotations for static > > functions in this file, which has caused warnings for functions > > that are not used in a given

Re: [PATCH] netfilter: ctnetlink: add more #ifdef around unused code

2016-04-18 Thread Pablo Neira Ayuso
On Sat, Apr 16, 2016 at 10:17:43PM +0200, Arnd Bergmann wrote: > A recent patch removed many 'inline' annotations for static > functions in this file, which has caused warnings for functions > that are not used in a given configuration, in particular when > CONFIG_NF_CONNTRACK_EVENTS is disabled:

[PATCH] netfilter: ctnetlink: add more #ifdef around unused code

2016-04-16 Thread Arnd Bergmann
A recent patch removed many 'inline' annotations for static functions in this file, which has caused warnings for functions that are not used in a given configuration, in particular when CONFIG_NF_CONNTRACK_EVENTS is disabled: nf_conntrack_netlink.c:572:15: 'ctnetlink_timestamp_size' defined but