Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

Hi Florian, Andrew, On Sun, Jul 9, 2017 at 7:28 PM, Andrew Lunn wrote: >> It sure does fix a real issue, but I am really concerned about the >> inability to test this patch in a configuration where we have multiple >> PHY(s) or MDIO device(s) hanging off the same MDIO bus and one

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

> It sure does fix a real issue, but I am really concerned about the > inability to test this patch in a configuration where we have multiple > PHY(s) or MDIO device(s) hanging off the same MDIO bus and one of those > requesting an EPROBE_DEFER. > > I currently don't have a setup where I could

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

On 07/02/2017 01:37 PM, Geert Uytterhoeven wrote: > On Tue, Jun 6, 2017 at 11:43 AM, Geert Uytterhoeven > wrote: >> On Tue, May 23, 2017 at 11:36 AM, Geert Uytterhoeven >> wrote: >>> On Fri, May 19, 2017 at 12:21 AM, Florian Fainelli

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

On Tue, Jun 6, 2017 at 11:43 AM, Geert Uytterhoeven wrote: > On Tue, May 23, 2017 at 11:36 AM, Geert Uytterhoeven > wrote: >> On Fri, May 19, 2017 at 12:21 AM, Florian Fainelli >> wrote: >>> On 05/18/2017 01:36 PM, Geert

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

Hi Florian, On Tue, May 23, 2017 at 11:36 AM, Geert Uytterhoeven wrote: > On Fri, May 19, 2017 at 12:21 AM, Florian Fainelli > wrote: >> On 05/18/2017 01:36 PM, Geert Uytterhoeven wrote: >>> On Thu, May 18, 2017 at 9:34 PM, Andrew Lunn

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

Hi Florian, On Fri, May 19, 2017 at 12:21 AM, Florian Fainelli wrote: > On 05/18/2017 01:36 PM, Geert Uytterhoeven wrote: >> On Thu, May 18, 2017 at 9:34 PM, Andrew Lunn wrote: > This most certainly works fine in the simple case where you have one PHY

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

On 05/18/2017 01:36 PM, Geert Uytterhoeven wrote: > Hi Andrew, > > On Thu, May 18, 2017 at 9:34 PM, Andrew Lunn wrote: This most certainly works fine in the simple case where you have one PHY hanging off the MDIO bus, now what happens if you have several?

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

Hi Andrew, On Thu, May 18, 2017 at 9:34 PM, Andrew Lunn wrote: >> > This most certainly works fine in the simple case where you have one PHY >> > hanging off the MDIO bus, now what happens if you have several? >> > >> > Presumably, the first PHY that returns EPROBE_DEFER will

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

> > This most certainly works fine in the simple case where you have one PHY > > hanging off the MDIO bus, now what happens if you have several? > > > > Presumably, the first PHY that returns EPROBE_DEFER will make the entire > > bus registration return EPROB_DEFER as well, and so on, and so

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

Hi Florian, On Thu, May 18, 2017 at 8:25 PM, Florian Fainelli wrote: > On 05/18/2017 05:59 AM, Geert Uytterhoeven wrote: >> If an Ethernet PHY is initialized before the interrupt controller it is >> connected to, a message like the following is printed: >> >> irq: no

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

On 05/18/2017 05:59 AM, Geert Uytterhoeven wrote: > If an Ethernet PHY is initialized before the interrupt controller it is > connected to, a message like the following is printed: > > irq: no irq domain found for /interrupt-controller@e61c ! > > However, the actual error is ignored,

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

Hi Andrew, On Thu, May 18, 2017 at 6:33 PM, Andrew Lunn wrote: >> >> phy = get_phy_device(mdio, addr, is_c45); >> >> if (IS_ERR(phy)) >> >> - return; >> >> + return PTR_ERR(phy); >> >> >> >> - rc = irq_of_parse_and_map(child, 0); >>

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

> >> phy = get_phy_device(mdio, addr, is_c45); > >> if (IS_ERR(phy)) > >> - return; > >> + return PTR_ERR(phy); > >> > >> - rc = irq_of_parse_and_map(child, 0); > >> + rc = of_irq_get(child, 0); > >> + if (rc == -EPROBE_DEFER) { > >> +

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

Hi Andrew, On Thu, May 18, 2017 at 6:09 PM, Andrew Lunn wrote: > On Thu, May 18, 2017 at 02:59:05PM +0200, Geert Uytterhoeven wrote: >> If an Ethernet PHY is initialized before the interrupt controller it is >> connected to, a message like the following is printed: >> >> irq:

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

On Thu, May 18, 2017 at 02:59:05PM +0200, Geert Uytterhoeven wrote: > If an Ethernet PHY is initialized before the interrupt controller it is > connected to, a message like the following is printed: > > irq: no irq domain found for /interrupt-controller@e61c ! > > However, the actual

Re: [PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

From: Geert Uytterhoeven Date: Thu, 18 May 2017 14:59:05 +0200 > If an Ethernet PHY is initialized before the interrupt controller it is > connected to, a message like the following is printed: > > irq: no irq domain found for /interrupt-controller@e61c ! > >

[PATCH] of_mdio: Fix broken PHY IRQ in case of probe deferral

If an Ethernet PHY is initialized before the interrupt controller it is connected to, a message like the following is printed: irq: no irq domain found for /interrupt-controller@e61c ! However, the actual error is ignored, leading to a non-functional (-1) PHY interrupt later: Micrel