Re: [PATCH] phylib: phy_ethtool_{sset,gset} -- check phydev for NULL

2007-05-21 Thread Andy Fleming
On May 11, 2007, at 05:58, Matvejchikov Ilya wrote: Signed-off-by: Matvejchikov Ilya [EMAIL PROTECTED] Acked-by: Andy Fleming [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] phylib: phy_ethtool_{sset,gset} -- check phydev for NULL

2007-05-14 Thread Matvejchikov Ilya
2007/5/11, Kumar Gala [EMAIL PROTECTED]: On May 11, 2007, at 8:49 AM, Matvejchikov Ilya wrote: 2007/5/11, Kumar Gala [EMAIL PROTECTED]: On May 11, 2007, at 5:58 AM, Matvejchikov Ilya wrote: Signed-off-by: Matvejchikov Ilya [EMAIL PROTECTED] --- diff -purN

Re: [PATCH] phylib: phy_ethtool_{sset,gset} -- check phydev for NULL

2007-05-11 Thread Matvejchikov Ilya
Signed-off-by: Matvejchikov Ilya [EMAIL PROTECTED] --- diff -purN linux-2.6.21-clean/drivers/net/phy/phy.c linux-2.6.21/drivers/net/phy/phy.c --- linux-2.6.21-clean/drivers/net/phy/phy.c2007-04-26 07:08:32.0 +0400 +++ linux-2.6.21/drivers/net/phy/phy.c 2007-05-04 08:22:01.0

Re: [PATCH] phylib: phy_ethtool_{sset,gset} -- check phydev for NULL

2007-05-11 Thread Kumar Gala
On May 11, 2007, at 5:58 AM, Matvejchikov Ilya wrote: Signed-off-by: Matvejchikov Ilya [EMAIL PROTECTED] --- diff -purN linux-2.6.21-clean/drivers/net/phy/phy.c linux-2.6.21/drivers/net/phy/phy.c --- linux-2.6.21-clean/drivers/net/phy/phy.c 2007-04-26 07:08:32.0 +0400 +++

Re: [PATCH] phylib: phy_ethtool_{sset,gset} -- check phydev for NULL

2007-05-11 Thread Kumar Gala
On May 11, 2007, at 8:49 AM, Matvejchikov Ilya wrote: 2007/5/11, Kumar Gala [EMAIL PROTECTED]: On May 11, 2007, at 5:58 AM, Matvejchikov Ilya wrote: Signed-off-by: Matvejchikov Ilya [EMAIL PROTECTED] --- diff -purN linux-2.6.21-clean/drivers/net/phy/phy.c

Re: [PATCH] phylib: phy_ethtool_{sset,gset} -- check phydev for NULL

2007-05-11 Thread Matvejchikov Ilya
2007/5/11, Kumar Gala [EMAIL PROTECTED]: On May 11, 2007, at 5:58 AM, Matvejchikov Ilya wrote: Signed-off-by: Matvejchikov Ilya [EMAIL PROTECTED] --- diff -purN linux-2.6.21-clean/drivers/net/phy/phy.c linux-2.6.21/drivers/net/phy/phy.c --- linux-2.6.21-clean/drivers/net/phy/phy.c

[PATCH] phylib: phy_ethtool_{sset,gset} -- check phydev for NULL

2007-05-10 Thread Matvejchikov Ilya
Good Day! The command 'brctl addbr br0 eth0' brings the kernel oops if the eth0 has PHY, but the phydev is NULL (for ex., ifconfig eth0 0.0.0.0 was not issued firstly) Call Trace: [C02CFBD0] [7FFF] 0x7fff (unreliable) [C02CFBE0] [C0109634] dev_ethtool+0x1b0/0xfac [C02CFCD0] [C0155EF0]

Re: [PATCH] phylib: phy_ethtool_{sset,gset} -- check phydev for NULL

2007-05-10 Thread Randy Dunlap
On Thu, 10 May 2007 21:29:51 +0400 Matvejchikov Ilya wrote: Good Day! The command 'brctl addbr br0 eth0' brings the kernel oops if the eth0 has PHY, but the phydev is NULL (for ex., ifconfig eth0 0.0.0.0 was not issued firstly) Call Trace: [C02CFBD0] [7FFF] 0x7fff (unreliable)

Re: [PATCH] phylib: phy_ethtool_{sset,gset} -- check phydev for NULL

2007-05-10 Thread Jeff Garzik
Randy Dunlap wrote: and I hope that Jeff prefers (as some others do): if (unlikely(phydev == NULL)) or even if (unlikely(!phydev)) That is indeed my preference :) Jeff - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to