Re: [PATCH] pktgen: potential double free of pktgen_dev's skb

2006-02-15 Thread Arthur Kepner
On Wed, 15 Feb 2006, David S. Miller wrote: > > I don't see how this fixes the race > Well, of course. I was just checking that you were paying attention. It looks like the right thing to do is to let the worker thread free up the skb in all cases. New patch soon. -- Arthur - To un

[PATCH] pktgen: potential double free of pktgen_dev's skb

2006-02-15 Thread Robert Olsson
Arthur Kepner writes: > There's a race in pktgen which can lead to a double > free of a pktgen_dev's skb. If a worker thread is in > the midst of doing fill_packet(), and the controlling > thread gets a "stop" message, the already freed skb > can be freed once again in pktgen_stop_device().

Re: [PATCH] pktgen: potential double free of pktgen_dev's skb

2006-02-15 Thread David S. Miller
From: Arthur Kepner <[EMAIL PROTECTED]> Date: Tue, 14 Feb 2006 13:55:58 -0800 (PST) > > There's a race in pktgen which can lead to a double > free of a pktgen_dev's skb. If a worker thread is in > the midst of doing fill_packet(), and the controlling > thread gets a "stop" message, the already fr

[PATCH] pktgen: potential double free of pktgen_dev's skb

2006-02-14 Thread Arthur Kepner
There's a race in pktgen which can lead to a double free of a pktgen_dev's skb. If a worker thread is in the midst of doing fill_packet(), and the controlling thread gets a "stop" message, the already freed skb can be freed once again in pktgen_stop_device(). This patch removes the race by settin