Re: [PATCH] qed: mark symbols static where possible

2016-09-07 Thread David Miller
From: Yuval Mintz Date: Wed, 7 Sep 2016 11:55:34 + >> We get a few warnings when building kernel with W=1: >> drivers/net/ethernet/qlogic/qed/qed_l2.c:112:5: warning: no previous >> prototype for 'qed_sp_vport_start' [-Wmissing-prototypes] >> >> >> In fact, these functions are only used

RE: [PATCH] qed: mark symbols static where possible

2016-09-07 Thread Yuval Mintz
> We get a few warnings when building kernel with W=1: > drivers/net/ethernet/qlogic/qed/qed_l2.c:112:5: warning: no previous > prototype for 'qed_sp_vport_start' [-Wmissing-prototypes] > > > In fact, these functions are only used in the file in which they are > declared and don't need a decl

[PATCH] qed: mark symbols static where possible

2016-09-07 Thread Baoyou Xie
We get a few warnings when building kernel with W=1: drivers/net/ethernet/qlogic/qed/qed_l2.c:112:5: warning: no previous prototype for 'qed_sp_vport_start' [-Wmissing-prototypes] drivers/net/ethernet/qlogic/qed/qed_l2.c:1593:6: warning: no previous prototype for 'qed_get_vport_stats' [-Wmissing-