Re: [PATCH] ravb: Consolidate clock handling

2017-10-13 Thread Simon Horman
On Thu, Oct 12, 2017 at 02:20:45PM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Thu, Oct 12, 2017 at 11:55 AM, Simon Horman wrote: > > On Thu, Oct 12, 2017 at 10:24:53AM +0200, Geert Uytterhoeven wrote: > >> The module clock is used for two purposes: > >> - Wake-on-LAN (WoL), which is op

Re: [PATCH] ravb: Consolidate clock handling

2017-10-12 Thread David Miller
From: Geert Uytterhoeven Date: Thu, 12 Oct 2017 10:24:53 +0200 > The module clock is used for two purposes: > - Wake-on-LAN (WoL), which is optional, > - gPTP Timer Increment (GTI) configuration, which is mandatory. > > As the clock is needed for GTI configuration anyway, WoL is always > ava

Re: [PATCH] ravb: Consolidate clock handling

2017-10-12 Thread Sergei Shtylyov
Hello! On 10/12/2017 11:24 AM, Geert Uytterhoeven wrote: The module clock is used for two purposes: - Wake-on-LAN (WoL), which is optional, - gPTP Timer Increment (GTI) configuration, which is mandatory. As the clock is needed for GTI configuration anyway, WoL is always available. Hence

Re: [PATCH] ravb: Consolidate clock handling

2017-10-12 Thread Niklas Söderlund
Hi Geert, Grate patch! Reviewed-by: Niklas Söderlund On 2017-10-12 10:24:53 +0200, Geert Uytterhoeven wrote: > The module clock is used for two purposes: > - Wake-on-LAN (WoL), which is optional, > - gPTP Timer Increment (GTI) configuration, which is mandatory. > > As the clock is needed f

Re: [PATCH] ravb: Consolidate clock handling

2017-10-12 Thread Geert Uytterhoeven
Hi Simon, On Thu, Oct 12, 2017 at 11:55 AM, Simon Horman wrote: > On Thu, Oct 12, 2017 at 10:24:53AM +0200, Geert Uytterhoeven wrote: >> The module clock is used for two purposes: >> - Wake-on-LAN (WoL), which is optional, >> - gPTP Timer Increment (GTI) configuration, which is mandatory. >>

Re: [PATCH] ravb: Consolidate clock handling

2017-10-12 Thread Simon Horman
On Thu, Oct 12, 2017 at 10:24:53AM +0200, Geert Uytterhoeven wrote: > The module clock is used for two purposes: > - Wake-on-LAN (WoL), which is optional, > - gPTP Timer Increment (GTI) configuration, which is mandatory. > > As the clock is needed for GTI configuration anyway, WoL is always >

[PATCH] ravb: Consolidate clock handling

2017-10-12 Thread Geert Uytterhoeven
The module clock is used for two purposes: - Wake-on-LAN (WoL), which is optional, - gPTP Timer Increment (GTI) configuration, which is mandatory. As the clock is needed for GTI configuration anyway, WoL is always available. Hence remove duplication and repeated obtaining of the clock by maki