Re: [PATCH] rose: correct integer overflow check

On Thu, Feb 18, 2016 at 04:03:16PM -0500, Insu Yun wrote: > > Because of the types on the right hand side of the comparison > the expressions are all promoted to unsigned. > > Did you look at the compiler's assembler output?  I did when > reviewing your patch. > > > I checked

Re: [PATCH] rose: correct integer overflow check

From: Insu Yun Date: Wed, 17 Feb 2016 15:25:13 -0500 > Since rose_ndevs is signed integer type, > it can be overflowed when it is negative. > > Signed-off-by: Insu Yun That's not how the expression is evaluated. Because of the types on the right hand

[PATCH] rose: correct integer overflow check

Since rose_ndevs is signed integer type, it can be overflowed when it is negative. Signed-off-by: Insu Yun --- net/rose/af_rose.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/net/rose/af_rose.c b/net/rose/af_rose.c index 129d357..4f37fae 100644 ---