Re: [PATCH] selftests: add a generic testsuite for ethernet device

2017-04-04 Thread Andrew Lunn
On Tue, Apr 04, 2017 at 09:56:04AM +0200, Corentin Labbe wrote: > On Mon, Apr 03, 2017 at 03:27:41PM +0200, Andrew Lunn wrote: > > > By ifnum, you mean by the order that "ip link" gives ? > > > > I've not checked if it remains in order as interfaces are hot > > plugged/unplugged. But i guess you

Re: [PATCH] selftests: add a generic testsuite for ethernet device

2017-04-04 Thread Corentin Labbe
On Mon, Apr 03, 2017 at 03:27:41PM +0200, Andrew Lunn wrote: > > By ifnum, you mean by the order that "ip link" gives ? > > I've not checked if it remains in order as interfaces are hot > plugged/unplugged. But i guess you are running tests direct after > boot, and unplugs/replugs are unlikely? >

Re: [PATCH] selftests: add a generic testsuite for ethernet device

2017-04-03 Thread Andrew Lunn
> By ifnum, you mean by the order that "ip link" gives ? I've not checked if it remains in order as interfaces are hot plugged/unplugged. But i guess you are running tests direct after boot, and unplugs/replugs are unlikely? Andrew

Re: [PATCH] selftests: add a generic testsuite for ethernet device

2017-04-03 Thread Corentin Labbe
On Fri, Mar 31, 2017 at 04:12:41PM +0200, Andrew Lunn wrote: > On Fri, Mar 31, 2017 at 02:57:52PM +0200, Corentin Labbe wrote: > > This patch add a generic testsuite for testing ethernet network device > > driver. > > > > Signed-off-by: Corentin Labbe > > --- > >

Re: [PATCH] selftests: add a generic testsuite for ethernet device

2017-03-31 Thread Andrew Lunn
On Fri, Mar 31, 2017 at 02:57:52PM +0200, Corentin Labbe wrote: > This patch add a generic testsuite for testing ethernet network device driver. > > Signed-off-by: Corentin Labbe > --- > tools/testing/selftests/net/Makefile | 2 +- >

[PATCH] selftests: add a generic testsuite for ethernet device

2017-03-31 Thread Corentin Labbe
Hello My original intent was to add network test to the kernelci project. Since they use kselftests, they forwarded me to this. This patch add a basic network test suite which do: - bring up netdev - change mac address - try some ethtool commands - bring down netdev The test is non disruptive,

[PATCH] selftests: add a generic testsuite for ethernet device

2017-03-31 Thread Corentin Labbe
This patch add a generic testsuite for testing ethernet network device driver. Signed-off-by: Corentin Labbe --- tools/testing/selftests/net/Makefile | 2 +- tools/testing/selftests/net/netdevice.sh | 185 +++ 2 files changed, 186