Re: [PATCH] skye/skge: sparse fix - data can't ever be bigger than LONG_MAX / HZ

2007-10-29 Thread Jeff Garzik
Auke Kok wrote: Trivial replacement - use INT_MAX instead here. Signed-off-by: Auke Kok [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] --- drivers/net/sk98lin/skethtool.c |4 ++-- drivers/net/skge.c |8 drivers/net/sky2.c |8 3 files changed,

Re: [PATCH] skye/skge: sparse fix - data can't ever be bigger than LONG_MAX / HZ

2007-10-29 Thread Stephen Hemminger
On Mon, 29 Oct 2007 06:05:14 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Auke Kok wrote: Trivial replacement - use INT_MAX instead here. Signed-off-by: Auke Kok [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] --- drivers/net/sk98lin/skethtool.c |4 ++-- drivers/net/skge.c

Re: [PATCH] skye/skge: sparse fix - data can't ever be bigger than LONG_MAX / HZ

2007-10-29 Thread Jeff Garzik
Stephen Hemminger wrote: Since these all use ethtool, shouldn't the checks be put into ethtool_phys_id rather than having the driver check? Seems quite reasonable to me. Jeff - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL

[PATCH] skye/skge: sparse fix - data can't ever be bigger than LONG_MAX / HZ

2007-10-26 Thread Auke Kok
Trivial replacement - use INT_MAX instead here. Signed-off-by: Auke Kok [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] --- drivers/net/sk98lin/skethtool.c |4 ++-- drivers/net/skge.c |8 drivers/net/sky2.c |8 3 files changed, 10 insertions(+),

Re: [PATCH] skye/skge: sparse fix - data can't ever be bigger than LONG_MAX / HZ

2007-10-26 Thread Stephen Hemminger
On Fri, 26 Oct 2007 15:10:28 -0700 Auke Kok [EMAIL PROTECTED] wrote: Trivial replacement - use INT_MAX instead here. Signed-off-by: Auke Kok [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Acked-by: Stephen Hemminger [EMAIL PROTECTED] Sure that works. Note: original code was copied from e100 which

Re: [PATCH] skye/skge: sparse fix - data can't ever be bigger than LONG_MAX / HZ

2007-10-26 Thread Kok, Auke
Stephen Hemminger wrote: On Fri, 26 Oct 2007 15:10:28 -0700 Auke Kok [EMAIL PROTECTED] wrote: Trivial replacement - use INT_MAX instead here. Signed-off-by: Auke Kok [EMAIL PROTECTED] Cc: [EMAIL PROTECTED] Acked-by: Stephen Hemminger [EMAIL PROTECTED] Sure that works. Note: original