Re: [PATCH] staging: fsl-dpaa2/ethsw: Fix TCI values overwrite

2018-03-28 Thread kbuild test robot
Hi Razvan, I love your patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on next-20180327] [cannot apply to v4.16-rc7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

RE: [PATCH] staging: fsl-dpaa2/ethsw: Fix TCI values overwrite

2018-03-28 Thread Razvan Stefanescu
.tu...@nxp.com>; stuyo...@gmail.com > Subject: Re: [PATCH] staging: fsl-dpaa2/ethsw: Fix TCI values overwrite > > On Tue, Mar 27, 2018 at 08:10:50AM -0500, Razvan Stefanescu wrote: > > Previous implementation overwrites PCP value, assuming the default value > is > >

Re: [PATCH] staging: fsl-dpaa2/ethsw: Fix TCI values overwrite

2018-03-27 Thread Andrew Lunn
On Tue, Mar 27, 2018 at 08:10:50AM -0500, Razvan Stefanescu wrote: > Previous implementation overwrites PCP value, assuming the default value is > 0, instead of 7. > > Avoid this by modifying helper function ethsw_port_set_tci() to > ethsw_port_set_pvid() and make it update only the vlan_id of

[PATCH] staging: fsl-dpaa2/ethsw: Fix TCI values overwrite

2018-03-27 Thread Razvan Stefanescu
Previous implementation overwrites PCP value, assuming the default value is 0, instead of 7. Avoid this by modifying helper function ethsw_port_set_tci() to ethsw_port_set_pvid() and make it update only the vlan_id of the tci_cfg struct. Signed-off-by: Razvan Stefanescu