[PATCH] stmmac: fix check for phydev being open

2015-09-07 Thread Alexey Brodkin
Current implementation via IS_ERR(phydev) may make no sense because of_phy_attach() returns NULL on failure instead of error value. Still for checking result of phy_connect() IS_ERR() is useful. So adding explicit check for NULL. Cc: Giuseppe Cavallaro Cc:

Re: [PATCH] stmmac: fix check for phydev being open

2015-09-07 Thread Sergei Shtylyov
Hello. On 09/07/2015 09:15 PM, Alexey Brodkin wrote: Current implementation via IS_ERR(phydev) may make no sense because of_phy_attach() returns NULL on failure instead of error value. Still for checking result of phy_connect() IS_ERR() is useful. So adding explicit check for NULL.