Re: [PATCH] sungem: PHY updates pause fixes

2007-01-04 Thread Eric Lemoine
On 1/4/07, David Miller [EMAIL PROTECTED] wrote: I've applied that patch, thanks. David, I suppose you've applied the locking patch as well... -- Eric - To unsubscribe from this list: send the line unsubscribe netdev in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] sungem: PHY updates pause fixes

2007-01-04 Thread David Miller
From: Eric Lemoine [EMAIL PROTECTED] Date: Thu, 4 Jan 2007 21:06:48 +0100 On 1/4/07, David Miller [EMAIL PROTECTED] wrote: I've applied that patch, thanks. David, I suppose you've applied the locking patch as well... No, not yet. Your locking patches are definitely 2.6.21 material, but

Re: [PATCH] sungem: PHY updates pause fixes

2007-01-04 Thread Eric Lemoine
On 1/4/07, David Miller [EMAIL PROTECTED] wrote: From: Eric Lemoine [EMAIL PROTECTED] Date: Thu, 4 Jan 2007 21:06:48 +0100 On 1/4/07, David Miller [EMAIL PROTECTED] wrote: I've applied that patch, thanks. David, I suppose you've applied the locking patch as well... No, not yet. Your

Re: [PATCH] sungem: PHY updates pause fixes

2007-01-04 Thread Benjamin Herrenschmidt
On Thu, 2007-01-04 at 21:57 +0100, Eric Lemoine wrote: On 1/4/07, David Miller [EMAIL PROTECTED] wrote: From: Eric Lemoine [EMAIL PROTECTED] Date: Thu, 4 Jan 2007 21:06:48 +0100 On 1/4/07, David Miller [EMAIL PROTECTED] wrote: I've applied that patch, thanks. David, I suppose

Re: [PATCH] sungem: PHY updates pause fixes

2007-01-03 Thread David Miller
From: Benjamin Herrenschmidt [EMAIL PROTECTED] Date: Wed, 03 Jan 2007 16:40:02 +1100 On the quad G5 which has tg3, I get Flow control is on for TX and on for RX. Let me double check if I'm on the same switch... Heh ! It's not :-) If I switch the cables, then pause is enabled on the sungem

[PATCH] sungem: PHY updates pause fixes

2007-01-02 Thread Benjamin Herrenschmidt
This patch adds support for a few more PHYs used by Apple and fixes advertising and detecting of Pause (we were missing setting the bit in MII_ADVERTISE and weren't testing in LPA for all PHYs). I only do it for gigabit capable PHYs for now. Note that I currently only advertise pause, not

Re: [PATCH] sungem: PHY updates pause fixes

2007-01-02 Thread David Miller
From: Benjamin Herrenschmidt [EMAIL PROTECTED] Date: Wed, 03 Jan 2007 15:58:05 +1100 This patch adds support for a few more PHYs used by Apple and fixes advertising and detecting of Pause (we were missing setting the bit in MII_ADVERTISE and weren't testing in LPA for all PHYs). I only do it

Re: [PATCH] sungem: PHY updates pause fixes

2007-01-02 Thread Benjamin Herrenschmidt
Thanks for finding these bugs, although that's really strange pause behavior you are seeing on your switches. By default, we advertise PAUSE but not ASYM PAUSE in the tg3 driver, and I get flow control on every switch I have here. Yeah, that's strange. I still have the debug values at

Re: [PATCH] sungem: PHY updates pause fixes

2007-01-02 Thread David Miller
From: Benjamin Herrenschmidt [EMAIL PROTECTED] Date: Wed, 03 Jan 2007 16:20:14 +1100 Now, I cross-over with a TG3 and I get: - I advertise 0x5e1 (hopefully same value) - I read in LPA 0xc5e1 from the TG3 (and that other register tells me Rx and Tx pause can be enabled). Does flow control

[PATCH] sungem: PHY updates pause fixes (#2)

2007-01-02 Thread Benjamin Herrenschmidt
This patch adds support for a few more PHYs used by Apple and fixes advertising and detecting of Pause (we were missing setting the bit in MII_ADVERTISE and weren't testing in LPA for all PHYs). Note that I currently only advertise pause, not asymetric pause. I don't know for sure the details

Re: [PATCH] sungem: PHY updates pause fixes

2007-01-02 Thread Benjamin Herrenschmidt
The one with only asym. support is a big Cisco Catalyst 3350 (well.. big but not that many ports :-) Ok, I got in the config of the switch with somebody who knows how to speak ciscong, and it seems that it defaults to flow control desired for send and off for receive on all ports, which means